382128 - Fix crash reporter description for non-firefox apps

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Dave Camp (:dcamp)]

The crash reporter description is too firefox-specific, should be specified by the XR app data.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Actually I would think that crashreporter.ini should be application (and locale) specific.
At least that's what we do currently.

Comment 2

[(not currently active) Ted Mielczarek]

Well it's going to wind up in toolkit/locales.  We could potentially add another file, like crashreporter-app.ini that had optional app-specific strings.  I don't want to encode stuff into the main crashreporter.ini since we'd like to continue to build and ship it with XULRunner.

Comment 3

[Axel Hecht [:Pike]]

Looking at the strings, are they really too firefox specific? I'd rather say the opposite way around. Anyway.

I'm tempted to say that we could just make browser overwrite the toolkit one at build time, but that seems to break for depend builds, at least I don't see a way to not break it.

For a xulrunner application, how would crashreporter even find the application specified information? Can that be done? I really just don't know. I'd ask Benjamin, so I do.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

(In reply to comment #3)
> For a xulrunner application, how would crashreporter even find the application
> specified information? Can that be done? I really just don't know. I'd ask
> Benjamin, so I do.

A xulrunner application could ship its own crashreporter.ini and stuff like the vendor and application name is already read from an extra file written from within the exception handler.

Comment 6

[(not currently active) Ted Mielczarek]

Turns out I'm going to fix this in bug 412989.

Comment 7

[(not currently active) Ted Mielczarek]

The l10n changes I checked in effectively fix this, once bug 412989 gets fixed Firefox will have its special text back.