Closed Bug 382172 Opened 13 years ago Closed 13 years ago

allow env var for extra uniqueness in symbols.txt file

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file, 1 obsolete file)

From bug 382141, it'd be nice to be able to upload symbols from experimental builds.  However, I'd like them to not clash with the symbols.txt files from the nightly builds, so it'd be good if we could set another env var and add its value in the symbols.txt filename.
Blocks: 382141
Attached patch MOZ_SYMBOLS_EXTRA_BUILDID (obsolete) — Splinter Review
This allows an env var called MOZ_SYMBOLS_EXTRA_BUILDID, so the symbols.txt file gets named like so:
$(MOZ_APP_NAME)-$(MOZ_APP_VERSION)-$(OS_ARCH)-$(BUILDID)$(MOZ_SYMBOLS_EXTRA_BUILDID)-symbols.txt
with an extra - prepended to MOZ_SYMBOLS_EXTRA_BUILDID if it's set.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #266279 - Flags: review?(benjamin)
Comment on attachment 266279 [details] [diff] [review]
MOZ_SYMBOLS_EXTRA_BUILDID

You should use a different variable name so that the user can specify this on the make commandline.
Attachment #266279 - Flags: review?(benjamin) → review-
Ok, should be replacable on the make commandline as well.
Attachment #266279 - Attachment is obsolete: true
Attachment #266318 - Flags: review?(benjamin)
Attachment #266318 - Flags: review?(benjamin) → review+
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.