allow env var for extra uniqueness in symbols.txt file

RESOLVED FIXED

Status

()

Toolkit
Crash Reporting
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
From bug 382141, it'd be nice to be able to upload symbols from experimental builds.  However, I'd like them to not clash with the symbols.txt files from the nightly builds, so it'd be good if we could set another env var and add its value in the symbols.txt filename.
(Assignee)

Updated

11 years ago
Blocks: 382141
(Assignee)

Comment 1

11 years ago
Created attachment 266279 [details] [diff] [review]
MOZ_SYMBOLS_EXTRA_BUILDID

This allows an env var called MOZ_SYMBOLS_EXTRA_BUILDID, so the symbols.txt file gets named like so:
$(MOZ_APP_NAME)-$(MOZ_APP_VERSION)-$(OS_ARCH)-$(BUILDID)$(MOZ_SYMBOLS_EXTRA_BUILDID)-symbols.txt
with an extra - prepended to MOZ_SYMBOLS_EXTRA_BUILDID if it's set.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #266279 - Flags: review?(benjamin)

Comment 2

11 years ago
Comment on attachment 266279 [details] [diff] [review]
MOZ_SYMBOLS_EXTRA_BUILDID

You should use a different variable name so that the user can specify this on the make commandline.
Attachment #266279 - Flags: review?(benjamin) → review-
(Assignee)

Comment 3

11 years ago
Created attachment 266318 [details] [diff] [review]
use a different name for the altered var

Ok, should be replacable on the make commandline as well.
Attachment #266279 - Attachment is obsolete: true
Attachment #266318 - Flags: review?(benjamin)

Updated

11 years ago
Attachment #266318 - Flags: review?(benjamin) → review+
(Assignee)

Comment 4

11 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.