Closed
Bug 382172
Opened 18 years ago
Closed 18 years ago
allow env var for extra uniqueness in symbols.txt file
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.38 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
From bug 382141, it'd be nice to be able to upload symbols from experimental builds. However, I'd like them to not clash with the symbols.txt files from the nightly builds, so it'd be good if we could set another env var and add its value in the symbols.txt filename.
|
Assignee | |
Comment 1•18 years ago
|
||
This allows an env var called MOZ_SYMBOLS_EXTRA_BUILDID, so the symbols.txt file gets named like so:
$(MOZ_APP_NAME)-$(MOZ_APP_VERSION)-$(OS_ARCH)-$(BUILDID)$(MOZ_SYMBOLS_EXTRA_BUILDID)-symbols.txt
with an extra - prepended to MOZ_SYMBOLS_EXTRA_BUILDID if it's set.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #266279 -
Flags: review?(benjamin)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 266279 [details] [diff] [review]
MOZ_SYMBOLS_EXTRA_BUILDID
You should use a different variable name so that the user can specify this on the make commandline.
Attachment #266279 -
Flags: review?(benjamin) → review-
|
|
Assignee | |
Comment 3•18 years ago
|
||
Ok, should be replacable on the make commandline as well.
Attachment #266279 -
Attachment is obsolete: true
Attachment #266318 -
Flags: review?(benjamin)
|
|
||
Updated•18 years ago
|
Attachment #266318 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•