382195 - "show all bookmark folders" button is slow when we're opening to the bookmarks root

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

"show all bookmark folders" button is slow when we're opening to the bookmarks root

for the common case, we recurse the whole tree in selectFolders() when what we want is really the first thing we pass in.

see also bug #381750 for a similar perf issue.

patch coming.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: similar in spirit to the fix for bug #381750

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: same patch, but remove trailing whitespace

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 266403 [details] [diff] [review]
same patch, but remove trailing whitespace

would take a review from Mano, too.

Comment 4

[Asaf Romano (gone)]

Seth, where's this button?

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: screen shot for Asaf

> Seth, where's this button?

In the "Add Bookmark" dialog.  (See attached screen shot)

Comment 6

[Asaf Romano (gone)]

ah, the expander ;)

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 266403 [details] [diff] [review]
same patch, but remove trailing whitespace

looks ok, r=me. thanks seth.

Comment 8

[Asaf Romano (gone)]

Comment on attachment 266403 [details] [diff] [review]
same patch, but remove trailing whitespace

nit: remove the braces around the last block.

r=mano otherwise.

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: patch, as checked in.

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.

Checking in tree.xml;
/cvsroot/mozilla/browser/components/places/content/tree.xml,v  <--  tree.xml
new revision: 1.72; previous revision: 1.71
done

Comment 11

[Al Billings [:abillings - ex-MoCo]]

Verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707270404 Minefield/3.0a7pre.

Are we really supposed to flicker with the repainting if I click this expander button over and over again? It's like when we close from the expanded view, we paint the scrollbars and folders higher up and then then paint over them again.

Comment 12

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv