Closed
Bug 382237
Opened 18 years ago
Closed 18 years ago
the profiler in xpctools hangs
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
People
(Reporter: mvl, Assigned: mvl)
Details
Attachments
(1 file)
|
4.94 KB,
patch
|
shaver
:
review+
|
Details | Diff | Splinter Review |
I enabled the xpctools (--enable-xpctools), and tried to use the profiler to profile an xpcshell script (export MOZILLA_JS_PROFILER_OUTPUT=/tmp/prof2.txt). That just made it hang at shutdown. It never writes anything.
Turns out it was a missing PR_UnLock().
Then it didn't output any data. That was a wrong check somewhere (missing a !)
Then I wanted it to show the time spend in the function itself, not in anything it calls. Needed to do some more work for that, but it now works.
Patch coming up
|
Assignee | |
Comment 1•18 years ago
|
||
|
||
Comment 2•18 years ago
|
||
Comment on attachment 266375 [details] [diff] [review]
patch v1
r=shaver -- that's a sweet bug you found in the first stanza!
Attachment #266375 -
Flags: review?(shaver) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
patch checked in
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•18 years ago
|
||
I've put up a doc on this on http://developer.mozilla.org/en/docs/XPCShell:Profiling
|
||
Updated•18 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•