382239 - make-jars.pl fails on non-English Windows due to bad username expand

Status: RESOLVED DUPLICATE of bug 561674

(Firefox Build System :: General, defect)

Description

[Mikko Ohtamaa]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fi; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 

The default username on Finnish Windows XP is "Järjestelmänvalvoja" (=Administrator) containing non-ASCII characters. make-jars.pl doesn't correctly escape them which leads to a script error.



Reproducible: Always

Steps to Reproduce:
1. Get Finnish Windows XP
2. Try build Minimo

Actual Results:  
make[1]: Entering directory `/cygdrive/c/minimo/mozilla/content/xbl/builtin/win'
+++ making chrome /cygdrive/c/minimo/mozilla/content/xbl/builtin/win  => ../../../../dist/bin/chrome/toolkit.jar
/usr/bin/perl.exe ../../../../config/preprocessor.pl  -DDEBUG -D_DEBUG -DDEBUG_J"rjestelm"nvalvoja -DTRACING -D_IMPL_NS_GFX -D_IMPL_NS_MSG_B
ASE -D_IMPL_NS_WIDGET  -DOSTYPE="WINNT5.1" -DOSARCH=WINNT -DBUILD_ID=0000000000 -DWINVER=0x501 -D_WIN32_WINNT=0x501 -D_WIN32_IE=0x0500 -DX_D
ISPLAY_MISSING=1 -DMOZILLA_VERSION="1.9a5pre" -DMOZILLA_VERSION_U=1.9a5pre -DHAVE_SNPRINTF=1 -D_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -D
XP_WIN32=1 -DHW_THREADS=1 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD_INO=d_ino -DSTDC_HEADERS=1 -DHAVE_DIRENT_H=1 -DH
AVE_GETOPT_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHAVE_MALLOC_H=1 -DHAVE_LIBM=1 -DNO_X11=1 -DMMAP_MISSES_WRITES=1 -DHAVE_STRERROR=1 -DHAV
E_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DVA_COPY=va_copy -DHAVE_VA_COPY=1 -DMOZ_EMBEDDING_LEVEL_BASIC=1 -DMOZ_EMBEDDING_LEVEL_MINIMAL=1
 -DMINIMO=1 -DMOZ_BUILD_APP=minimo -DMOZ_XUL_APP=1 -DMOZ_DEFAULT_TOOLKIT="cairo-windows" -DMOZ_THEBES=1 -DMOZ_CAIRO_GFX=1 -DMOZ_DISTRIBUTION
_ID="org.mozilla" -DIBMBIDI=1 -DMOZ_JSLOADER=1 -DMOZ_NO_XPCOM_OBSOLETE=1 -DMOZ_NO_FAST_LOAD=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_FEEDS=1 -DM
OZ_STORAGE=1 -DNS_DISABLE_LOGGING=1 -DHAVE___CXA_DEMANGLE=1 -DMOZ_DEMANGLE_SYMBOLS=1 -DMOZ_USER_DIR="Mozilla" -DMOZ_STATIC_BUILD=1 -DEXPORT_
JS_API=1 -DHAVE_STDINT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_UINT64_T=1 -DMOZ_XUL=1 -DMOZ_RDF=1 -DMOZ_MORK=1 -DMOZ_DLL_SUFFIX=".dll" -DJS_THREADSAF
E=1 -DMOZ_REFLOW_PERF=1 -DMOZ_REFLOW_PERF_DSP=1 -DMOZILLA_LOCALE_VERSION="1.9a1" -DMOZILLA_REGION_VERSION="1.9a1" -DMOZILLA_SKIN_VERSION="1.
8"  platformHTMLBindings.xml > ../../../../dist/chrome-stage/chrome/toolkit/content/global/platformHTMLBindings.xml../../../../config/prepro
cessor.pl: invalid argument to -D: DEBUG_J"rjestelm"nvalvoja
Preprocessing of platformHTMLBindings.xml failed: 255 at ../../../../config/make-jars.pl line 496, <STDIN> line 2.
make[1]: *** [libs] Error 255
make[1]: Leaving directory `/cygdrive/c/minimo/mozilla/content/xbl/builtin/win'
make: *** [all] Error 2

Expected Results:  
Build success

Comment 1

[Mikko Ohtamaa]

The problem seems to be in deeper autoconf/automake system.

Workaround is to edit config/autoconf.mk after it has been generated and fix the define.

Comment 2

[(not currently active) Ted Mielczarek]

http://mxr.mozilla.org/mozilla/source/configure.in#

That define gets set right there.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This is going to go away when Bug 561674 lands.