User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:126.96.36.199) Gecko/20070523 Firefox/188.8.131.52 Build Identifier: In Bug 361025, a patch was dropped. Could you apply this patch? Reproducible: Always
Attachment 266446 [details] [diff] applies to the trunk OK and I was able to generate a couple of Camellia keys with symkeyutil but the Camellia tests in all.sh fail. It appears that some of the bltests have not been checked in. I get cvs server: cannot find module `nss/cmd/bltest/tests/camellia_ecb' - ignored cvs [checkout aborted]: cannot expand modules
Nail, Any parts of the patch for bug 361025 that were not applied to the trunk should be considered part of this bug. As you find files in NSS that should have been changed, but whose patches were not apparently committed, please note them in this bug, and attach patches for them to this bug (probably the same patches found in bug 361025).
Comment on attachment 266446 [details] [diff] [review] patch for nss/cmd/symkeyutil Please ignore comment 2. All QA test pass with this patch after all.
Comment on attachment 266446 [details] [diff] [review] patch for nss/cmd/symkeyutil Since I did not modify this patch I'll review it myself
Checking in cmd/symkeyutil/symkey.man; /cvsroot/mozilla/security/nss/cmd/symkeyutil/symkey.man,v <-- symkey.man new revision: 1.2; previous revision: 1.1 done Checking in cmd/symkeyutil/symkeyutil.c; /cvsroot/mozilla/security/nss/cmd/symkeyutil/symkeyutil.c,v <-- symkeyutil.c new revision: 1.10; previous revision: 1.9 done