382297 - use a single PDB file per library (back out 286179)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

We moved to a single pdb file per object file in bug 286179 to make parallel builds work.  With Visual Studio 2005/VC8, this is no longer necessary -- there's a separate server process that manages all access to pdb files, and we're actually slowing down debug builds now.

Before backing out this patch, when linking layout in a debug build, mspdbsrv gets to upwards of 500mb and takes around 3-4 min on my laptop.  After backing it out, it doesn't go above 100mb and takes about 1.5 min to link.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: go back to using a single PDB per library

Go back to using a single PDB per library.  This will break -jN builds on anything less than VC8.  I think that's fine, because anything less than VC8 isn't supported, yes?

Comment 2

[Benjamin Smedberg]

Do we need VC8SP1 for this? I know that we haven't seen the slowdowns of mspdbsrv on the original release of VC8 (which many people are still using, including the tinderboxen).

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Hm, not sure; I have SP1 installed.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #1)
> I think that's fine, because anything less than VC8
> isn't supported, yes?

Doh, I thought vc71 was still supported, just not what the official builds were made with.

Comment 5

[Benjamin Smedberg]

VC71 still works (and would continue to work with this patch as long as you don't use -jN)... we don't test it, and if it breaks we'd expect people who care to provide patches.

Comment 6

[Benjamin Smedberg]

Comment on attachment 266453 [details] [diff] [review]
go back to using a single PDB per library

Bumping this to Ted for investigations.

Comment 7

[(not currently active) Ted Mielczarek]

vlad: have you seen this:
http://support.microsoft.com/kb/935225 ?  It's a hotfix for MSPDBSRV on VC8SP1.

If not, can you try it out?  Also, I saw something (can't remember where) that led me to believe that VC71 might have mspdbsrv as well.  I don't have it installed (just VC2k3 Toolkit), but maybe bent can investigate.  I think it lives in Common7\IDE.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 266453 [details] [diff] [review]
go back to using a single PDB per library

r=me, we could use a comment on a build page somewhere mentioning that make -jN + vc7.1 will be broken.

Comment 9

[Nickolay_Ponomarev]

Checking in config/rules.mk;
/cvsroot/mozilla/config/rules.mk,v  <--  rules.mk
new revision: 3.563; previous revision: 3.562
done

Comment 10

[Eric Shepherd [:sheppy]]

How does this affect developers, so I can document this?

Comment 11

[(not currently active) Ted Mielczarek]

I guess the dev-doc-needed is only in reference to comment 8. We don't officially support Visual C++ 2003 on the trunk anyway (I don't think), so maybe it's not an issue.

Comment 12

[Eric Shepherd [:sheppy]]

Added a note about this here:

https://developer.mozilla.org/en/Windows_Build_Prerequisites#Microsoft_Visual_C.2b.2b_%28MSVC%29