Closed Bug 382447 Opened 17 years ago Closed 17 years ago

"Show passwords" button in preferences should be renamed


(Firefox :: Settings UI, defect)

Not set



Firefox 3 beta5


(Reporter: wgianopoulos, Assigned: Dolske)



(Keywords: late-l10n)


(1 file, 1 obsolete file)

Currently, to show the saved passwords you go to Tools -> Options -> Security then click a show passwords button which brings up a page that does not show passwords but has another button labeled Show passwords .  This is a bit klunky and confusing to the user.

I suggest changing the button label on the Tools -> Options -> Security page from "Show Passwords..." to "Saved logins..." or something similar.
OS: Windows XP → All
Hardware: PC → All
Summary: Show password option page should be renamed → "Show passwords" button in preferences should be renamed (Show Logins?)
beltzner: "Show Logins..." or "Saved Logins..." or something else?
Flags: blocking-firefox3?
Keywords: uiwanted
"Saved Passwords..." for the button.
Then we'll also need to change the string at the top of the password manager to say "Password Manager has saved the passwords for the following sites:"

Not a blocker, but I'll approve the patch.
Flags: blocking-firefox3? → blocking-firefox3-
Whiteboard: [wanted-firefox3]
Attached patch Patch for review, v.1 (obsolete) — Splinter Review
This changes the button, and I reworded the resulting window's title a spiel a bit to better match Cookies and similar dialogs. I thought about using "logins" instead of "passwords", which is technically more complete/correct, but the task emphasis here is really on "passwords", and that's more likely to catch one's eye.

I do note that we currently have "Show Cookies..." and "Show Passwords..." buttons. Should I change the cookies button to "Saved Cookies..." for consistency? [Phil Hartman's 'Anal Retentive UI Designer' character is very concerned about this problem.]
Assignee: nobody → dolske
Attachment #285645 - Flags: ui-review?(beltzner)
Flags: wanted-firefox3+
Whiteboard: [wanted-firefox3]
Comment on attachment 285645 [details] [diff] [review]
Patch for review, v.1

No need to update the cookie button, since in that case we *are* showing the cookies; in this case we're just showing the list of saved passwords
Attachment #285645 - Flags: ui-review?(beltzner)
Attachment #285645 - Flags: ui-review+
Attachment #285645 - Flags: approval1.9+
Dolske can land his own patches.
Keywords: checkin-needed
Entity names need revved, too, and I'd not sure is wallet/SM are using these strings or not.
Whoops, this got dropped on the floor. Checked with beltzner, and we're still good to take this for B5. Updated patch coming up...
Keywords: late-l10n
Target Milestone: --- → Firefox 3 beta5
Attached patch Patch v.2Splinter Review
This changed the entity names, removes an unused string, and syncs back to trunk.
Attachment #285645 - Attachment is obsolete: true
Comment on attachment 308064 [details] [diff] [review]
Patch v.2

Attachment #308064 - Flags: approval1.9+
Checking in browser/components/preferences/security.xul;
  new revision: 1.23; previous revision: 1.22
Checking in browser/locales/en-US/chrome/browser/preferences/security.dtd;
  new revision: 1.9; previous revision: 1.8
Checking in browser/locales/en-US/chrome/help/prefs.xhtml;
  new revision: 1.60; previous revision: 1.59
Checking in toolkit/components/passwordmgr/content/passwordManager.js;
  new revision: 1.25; previous revision: 1.24
Checking in toolkit/components/passwordmgr/content/passwordManager.xul;
  new revision: 1.17; previous revision: 1.16
Checking in toolkit/components/passwordmgr/content/passwordManagerExceptions.xul;
  new revision: 1.2; previous revision: 1.1
Checking in toolkit/locales/en-US/chrome/passwordmgr/passwordManager.dtd;
  new revision: 1.7; previous revision: 1.6
Checking in toolkit/locales/en-US/chrome/passwordmgr/;
  new revision: 1.18; previous revision: 1.17

Closed: 17 years ago
Resolution: --- → FIXED
Summary: "Show passwords" button in preferences should be renamed (Show Logins?) → "Show passwords" button in preferences should be renamed
You need to log in before you can comment on or make changes to this bug.