382471 - Crash [@ nsView::CalcWidgetBounds] when trying to print any select

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, when trying to print this testcase, current trunk Mozilla builds crash.

Talkback ID: TB32666573M
nsView::CalcWidgetBounds  [mozilla/view/src/nsview.cpp, line 361]
nsIView::CreateWidget  [mozilla/view/src/nsview.cpp, line 626]
nsCSSFrameConstructor::InitializeSelectFrame  [mozilla/layout/base/nscssframeconstructor.cpp, line 5054]
nsCSSFrameConstructor::ConstructSelectFrame  [mozilla/layout/base/nscssframeconstructor.cpp, line 4944]
nsCSSFrameConstructor::ConstructHTMLFrame  [mozilla/layout/base/nscssframeconstructor.cpp, line 5336]
nsCSSFrameConstructor::ConstructFrameInternal  [mozilla/layout/base/nscssframeconstructor.cpp, line 7559]
nsCSSFrameConstructor::ConstructFrame  [mozilla/layout/base/nscssframeconstructor.cpp, line 7429]
nsCSSFrameConstructor::ProcessChildren  [mozilla/layout/base/nscssframeconstructor.cpp, line 11269]

According to bug 381746, comment 14, this is a regression from bug 381746.

Comment 1

[Eli Friedman]

Ugh, me being unbelievably stupid; I'll have a patch later.

Comment 2

[Peter van der Woude [:Peter6]]

It would be nice to get this fixed before 1.9 Alpha 5
The tree will close in a few hours

Comment 3

[Eli Friedman]

Attachment: Patch

I don't have the time today to test/check this in, but if someone is willing, that would be nice.

Comment 4

[Hank Mills]

(In reply to comment #3)
> Created an attachment (id=266669) [details]
> Patch
> 
> I don't have the time today to test/check this in, but if someone is willing,
> that would be nice.
> 

Tried it on a mac, compile failed with:

 /Developer/moz/mozilla/view/src/nsView.cpp
/Developer/moz/mozilla/view/src/nsView.cpp: In member function 'nsRect nsView::CalcWidgetBounds(nsWindowType)':
/Developer/moz/mozilla/view/src/nsView.cpp:359: error: 'Type' was not declared in this scope
make[5]: *** [nsView.o] Error 1
make[4]: *** [libs] Error 2
make[3]: *** [libs_tier_gecko] Error 2
make[2]: *** [tier_gecko] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Adding 

  nsWindowType Type;

allowed it to compile and I didn't crash on the testcase. Hope that helps.

Comment 5

[Hank Mills]

Attachment: autocomplete alignment problem

The patch along with the change I mentioned in my previous comment apparently cause the autocomplete to render in the incorrect location on a mac.

Comment 6

[Eli Friedman]

> Adding 
> 
>   nsWindowType Type;
> 
> allowed it to compile and I didn't crash on the testcase. Hope that helps.

That correction is wrong... "Type" should be "aType"; I just accidentally zapped the "a".

Comment 7

[Hank Mills]

(In reply to comment #6)
> That correction is wrong... "Type" should be "aType"; I just accidentally
> zapped the "a".
> 

yeah, I realized that later. Making that change it works great.

Comment 8

[[:Aleksej]]

Confirmed with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070531 Minefield/3.0a5pre (printing to PostScript).
OS → All

Will get the tb id if needed.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in