Closed Bug 382665 Opened 15 years ago Closed 15 years ago

Use a better icon for the crash reporter on OS X

Categories

(Toolkit :: Crash Reporting, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

Details

Attachments

(1 file)

The Crash Reporter client currently uses some generic looking icon on OS X.  We should use something better.  I borrowed the updater icon on Windows, maybe we can do the same here?
To make an icon for an application, you need to create an icns file. There is an application that comes with the Developer Tools called Icon Composer. Use that to create the icns file.

Make that icns file appear in the Resources/ directory of your built application, and make sure it has the same name as your application, and you should be good to go, if I'm remembering all of this correctly.
updater's icon is better than the generic app icon, and roughly the right motif, so if there's not a designer free to do better, that would placate me.

(In reply to comment #1)

> Make that icns file appear in the Resources/ directory of your built
> application, and make sure it has the same name as your application, and you
> should be good to go, if I'm remembering all of this correctly.

The icon filename needs to be specified as the CFBundleIconFile in the app's Info.plist (the field is present, but currently blank, in crashreporter's Info.plist).
This just copies the updater icon, like I did on Windows.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #268111 - Flags: review?(mark)
Comment on attachment 268111 [details] [diff] [review]
copy updater.icns

The binary file isn't included in the diff, but I looked at toolkit/mozapps/update/src/updater/macbuild/Contents/Resources/updater.icns.
Attachment #268111 - Flags: review?(mark) → review+
Yep, that's what I copied.  It's generic enough that I think it will be ok.  Checked in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.