Closed Bug 382681 Opened 14 years ago Closed 14 years ago
Unsafe DOM mutation events in scrollable frame
Using DOM mutation events it is possible to trash the UI so that the browser is unresponsive. See related bug 382568 and bug 355548 for more related test cases.
I get 100% cpu on trunk also. You mean that shouldn't happen?
if the UI is still responsive, then it is not so bad. On branches the UI stop working, and that is equivalent to "denial of service".
Oh, indeed, the UI gets unresponsive on trunk too.
Version: 1.8 Branch → Trunk
On linux (trunk/1.8) I get endless loop of JS's "too much recursion"s (which as such isn't Security-Sensitive, IMO). bug 382568 and bug 355548 are crashers.
IMO, it is security sensitive because it suggests a pattern to exploit things in a way similar to those. Should we file a metabug or whatever to keep these guys together?
Ok, this testcase does crash 1.8 and 1.8.0 on MacOS for me it was just a matter of skipping a couple of legitimate mutation events and doing nasty stuff on the vulnerable one.
Attachment #266803 - Attachment is obsolete: true
Crashes on Linux too. Severity elevated, title adjusted...
Severity: normal → critical
Summary: Suspicious DOM mutation events in scrollable frame → Unsafe DOM mutation events in scrollable frame
Just don't propagate any mutation events from native anonymous content. IsAnonymousForEvents() is needed because XUL has its own implementation for IsNativeAnonymous(). This fixes also Bug 382568.
attachment 267939 [details] [diff] [review] fixes also bug 382700. Note, I didn't change nsGenericDOMDataNode::HandleDOMEvent to check nativeness, because it doesn't implement SetNativeAnonymous properly and native anon text nodes are AFAIK always inside native anonymous elements. (This all ofc works properly on trunk.)
Whiteboard: [sg:low dos] (related to worse bugs?) need r/sr=sicking
Whiteboard: [sg:low dos] (related to worse bugs?) need r/sr=sicking → [sg:low dos] (related to worse bugs?)
Comment on attachment 267939 [details] [diff] [review] proposed patch approved for 184.108.40.206 and 220.127.116.11, a=dveditz for release-drivers
Checked in to branches
Verified on Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:18.104.22.168pre) Gecko/20070810 Firefox/22.214.171.124pre Fx15012 crashed but Fx15013pre did not.
Whiteboard: [sg:low dos] (related to worse bugs?) → [sg:low dos] keep private until 355548 is fixed
Whiteboard: [sg:low dos] keep private until 355548 is fixed → [sg:dos] keep private until 355548 is fixed on branches
You need to log in before you can comment on or make changes to this bug.