382685 - Allow selection of files with type TEXT in Open File… dialog

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: patch

Gecko supports mapping files with Mac type code TEXT to plain text, so local files of type TEXT with no extension can be displayed as plain text.  We already support  opening these files via drag-drop to the content area and on the app/Dock icon, so we should fix our Open File… filter to match.

(It's also halfway to 4xp and p-safari for old HTML documents, but the other half--sniffing local files for HTML--needs Gecko.)

cl, this seems like your kind of patch; care to review?

Comment 1

[Chris Lawson (gone)]

The "Gecko half" of this bug is bug 45441, for the record. This bug doesn't strictly require that one to be fixed first, but it sure would be nice to have.

r=me on the patch.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 266806 [details] [diff] [review]
patch

Marking cl's r+ from comment 1 and targeting smorgan for sr.

Comment 3

[Stuart Morgan]

Comment on attachment 266806 [details] [diff] [review]
patch

sr=smorgan

Comment 4

[froodian (Ian Leue)]

Checked in on trunk and MOZILLA_1_8_BRANCH.