Closed Bug 382765 Opened 13 years ago Closed 13 years ago

need to set plugin window x and y coords in CG mode

Categories

(Core :: Plug-ins, defect, major)

x86
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla1.9alpha6

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

The current CG NPAPI impl does not set x and y coords on the plugin window. We need to do that.
Flags: blocking1.9+
Attached patch fix v1.0Splinter Review
Attachment #266869 - Flags: review?(sfraser_bugs)
Attachment #266869 - Flags: superreview?(roc)
Comment on attachment 266869 [details] [diff] [review]
fix v1.0

This looks fine. Is it documented anywhere that the CGContext coordinates for plugins are top-left based (i.e. flipped)?
Attachment #266869 - Flags: review?(sfraser_bugs) → review+
I don't know of it being documented anywhere. This is what WebKit does though, not sure where we'd document it. Maybe in the CG drawing model spec?
Attachment #266869 - Flags: superreview?(roc) → superreview+
CG defaults to bottom-left (PostScript-style).
landed on trunk
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.