382781 - Kill mail3PaneWindowVertLayout.xul

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

Now that we have mail.pane_config.dynamic and we have no profiles using mail.pane_config we can remove it and mail3PaneWindowVertLayout.xul

Comment 1

[[e-mail]]

Attachment: Proposed patch

Some of the files or code blocks may be obsolete but that's a separate bug.

Comment 2

[Scott MacGregor]

Comment on attachment 266891 [details] [diff] [review]
Proposed patch

looks good Neil.

Comment 3

[Karsten Düsterloh]

Comment on attachment 266891 [details] [diff] [review]
Proposed patch

>Index: mailnews/base/resources/content/manifest.rdf
>===================================================================

Yeah, you said 
> Some of the files or code blocks may be obsolete but that's a separate bug.
but I wonder what's the point of changing a file that itself should be removed anyway?
I mean, this manifest.rdf has a contents.rdf next to it, it's out of sync with that contexts.rdf (aka "broken") and not used or referenced anywhere...
I think we can just remove mailnews/base/resources/content/manifest.rdf instead of "fixing" it (maybe in a follow-up bug, I don't care, but I think now is the time to shoot it on drive-by ;-) ).

Furthermore, the default setting of mail.pane_config in mailnews/mailnews.js, line 178, should also be removed.


r=me with that.

Comment 4

[[e-mail]]

Fix checked in.

Comment 5

[[e-mail]]

Attachment: Bustage fix

Opening the View/Layout menu doesn't work, because the code is still looking for the old pref (well the function that used to retrieve the old pref).

Comment 6

[Karsten Düsterloh]

Comment on attachment 276466 [details] [diff] [review]
Bustage fix

Oops...