382798 - compilation with java 1.5+ fails, because of "enum" keyword

Status: RESOLVED WONTFIX

(Directory :: LDAP Java SDK, defect)

Description

[Bert]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.3) Gecko/20070309 Firefox/2.0.0.3
Build Identifier: 4.1.7 ldapsdk_java_20020819

The java ldap sdk won't compile in java version 1.5 or higher (errors: see "actual results")

Reason: The reserved Java keyword "enum" is used as variable name.

Fix: Please rename the local variables named "enum" to e.g. "enumeration" in the following source files:
- LDAPConnection.java
- LDAPEntryChangeControl.java
- LDAPPersistSearchControl.java
- RDN.java

Reproducible: Always

Steps to Reproduce:
download sdk.zip, create a sample project "ldaplib" in Eclipse 3.2.2 using Java6.Update1:
- add external jar to build path: jss32_stub.jar from: mozilla/directory/java-sdk/ldapjdk/lib
- import java source files from "mozilla/directory/java-sdk/ldapjdk/netscape"

Actual Results:  
Severity and Description	Path	Resource	Location
Enumeration cannot be resolved	ldaplib/src/netscape/ldap	LDAPConnection.java	line 4522
Syntax error on token "enum", delete this token	ldaplib/src/netscape/ldap	LDAPConnection.java	line 4522
Syntax error on token "enum", invalid Expression	ldaplib/src/netscape/ldap	LDAPConnection.java	line 4523
Syntax error on token "enum", invalid Expression	ldaplib/src/netscape/ldap	LDAPConnection.java	line 4524
BEREnumerated cannot be resolved	ldaplib/src/netscape/ldap/controls	LDAPEntryChangeControl.java	line 110
Syntax error on token "enum", delete this token	ldaplib/src/netscape/ldap/controls	LDAPEntryChangeControl.java	line 110
Syntax error on token "enum", invalid Expression	ldaplib/src/netscape/ldap/controls	LDAPEntryChangeControl.java	line 112
BEREnumerated cannot be resolved	ldaplib/src/netscape/ldap/controls	LDAPPersistSearchControl.java	line 266
Syntax error on token "enum", delete this token	ldaplib/src/netscape/ldap/controls	LDAPPersistSearchControl.java	line 266
Syntax error on token "enum", invalid Expression	ldaplib/src/netscape/ldap/controls	LDAPPersistSearchControl.java	line 268
Enumeration cannot be resolved	ldaplib/src/netscape/ldap/util	RDN.java	line 405
Syntax error on token "enum", delete this token	ldaplib/src/netscape/ldap/util	RDN.java	line 405
Syntax error on token "enum", delete this token	ldaplib/src/netscape/ldap/util	RDN.java	line 410
Syntax error on token "enum", invalid Expression	ldaplib/src/netscape/ldap/util	RDN.java	line 409


Expected Results:  
No compilation errors

Comment 1

[Mark Smith [:mcs]]

Thanks for reporting this problem.  I added Nathan and Rich to the bug CC.  This should be an easy fix... does anyone have a patch?

Comment 2

[nkinder]

This was fixed quite some time ago (in 2004).  It looks like you're using a zipfile of source from 2002.  You should grab the source using a newer tag from CVS (such as the LDAPJavaSDK_418 tag).

Comment 3

[Bert]

The zip is right from http://www.mozilla.org/directory/javasdk.html
Unfortunately the JAva SDK web page lists 4.1.7 as most current version.

In this case, if possible please update the version info on the SDK web page and remove the outdated zip. Thank you

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Not activity for at least 6 years, closing.