Wrong gzip comment process in HTTP Compress converter

RESOLVED FIXED in mozilla1.9beta2

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: soflare, Assigned: soflare)

Tracking

Trunk
mozilla1.9beta2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4 XPCOMViewer/0.9.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4

I think it must be a typo. In file netwerk/streamconv/converters/nsHTTPCompressConv.cpp

 case GZIP_COMMENT:
     if (mFlags & GZIP_COMMENT)
     {

It should be:

 case GZIP_COMMENT:
     if (mFlags & COMMENT)
     {


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Updated

11 years ago
Version: unspecified → Trunk
(Assignee)

Comment 1

11 years ago
Created attachment 287508 [details] [diff] [review]
fix

Add a fix.
Attachment #287508 - Flags: review?(bzbarsky)
Assignee: nobody → solar
Comment on attachment 287508 [details] [diff] [review]
fix

Yeah, makes sense.  biesi, can you look too?
Attachment #287508 - Flags: superreview?(cbiesinger)
Attachment #287508 - Flags: review?(bzbarsky)
Attachment #287508 - Flags: review+
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #287508 - Flags: superreview?(cbiesinger) → superreview+
Attachment #287508 - Flags: approval1.9?

Updated

11 years ago
Attachment #287508 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Thanks for the patch!

Checking in netwerk/streamconv/converters/nsHTTPCompressConv.cpp;
/cvsroot/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp,v  <--  nsHTTPCompressConv.cpp
new revision: 1.28; previous revision: 1.27
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
You need to log in before you can comment on or make changes to this bug.