Closed
Bug 382849
Opened 18 years ago
Closed 18 years ago
Wrong gzip comment process in HTTP Compress converter
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9beta2
People
(Reporter: soflare, Assigned: soflare)
Details
Attachments
(1 file)
|
1.05 KB,
patch
|
bzbarsky
:
review+
Biesinger
:
superreview+
sayrer
:
approval1.9+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4 XPCOMViewer/0.9.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.8.1.4) Gecko/20070515 Firefox/2.0.0.4
I think it must be a typo. In file netwerk/streamconv/converters/nsHTTPCompressConv.cpp
case GZIP_COMMENT:
if (mFlags & GZIP_COMMENT)
{
It should be:
case GZIP_COMMENT:
if (mFlags & COMMENT)
{
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
|
||
Updated•18 years ago
|
Version: unspecified → Trunk
|
||
Updated•18 years ago
|
Assignee: nobody → solar
|
||
Comment 2•18 years ago
|
||
Comment on attachment 287508 [details] [diff] [review]
fix
Yeah, makes sense. biesi, can you look too?
Attachment #287508 -
Flags: superreview?(cbiesinger)
Attachment #287508 -
Flags: review?(bzbarsky)
Attachment #287508 -
Flags: review+
|
|
||
Updated•18 years ago
|
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Updated•18 years ago
|
Attachment #287508 -
Flags: superreview?(cbiesinger) → superreview+
|
|
||
Updated•18 years ago
|
Attachment #287508 -
Flags: approval1.9?
|
||
Updated•18 years ago
|
Attachment #287508 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•18 years ago
|
Keywords: checkin-needed
|
|
||
Comment 3•18 years ago
|
||
Thanks for the patch!
Checking in netwerk/streamconv/converters/nsHTTPCompressConv.cpp;
/cvsroot/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp,v <-- nsHTTPCompressConv.cpp
new revision: 1.28; previous revision: 1.27
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
You need to log in
before you can comment on or make changes to this bug.
Description
•