382870 - Migrator does not recognize old news directory

Status: NEW

(SeaMonkey :: Startup & Profiles, defect)

Description

[Jürgen 'JiHa' Harter]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070601 Mnenhy/0.7.5.0 SeaMonkey/2.0a1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070601 Mnenhy/0.7.5.0 SeaMonkey/2.0a1pre

The migrator that moves an old SeaMonkey 1.x profile to a toolkit based profile for SM 2 does not use the old news directory (for offline news and *.msf).

Reproducible: Always

Steps to Reproduce:
1. Have a SeaMonkey 1.x profile with a news directory and a news.rc file at a non-standard place (out of the profile directory, see prefs below). 
2. Migrate the Profile to a toolkit based.

Actual Results:  
See, that the old news.rc file is used at it's old place but the news directory is now at it's standard place.

Expected Results:  
The old news directory should be used.

In my prefs.js of the SM 1.x profile I have:
user_pref("mail.root.nntp", "/media/hdb5/Eigene Dateien/Mozilla/Moz-shared-Profile/News");

user_pref("mail.root.nntp-rel", "[ProfD]../../../../../media/hdb5/Eigene Dateien/Mozilla/Moz-shared-Profile/News");

user_pref("mail.server.server4.directory", "/media/hdb5/Eigene Dateien/Mozilla/Moz-shared-Profile/News/news.arcor.de");

user_pref("mail.server.server4.directory-rel", "[ProfD]../../../../../media/hdb5/Eigene Dateien/Mozilla/Moz-shared-Profile/News/news.arcor.de");

user_pref("mail.server.server4.newsrc.file", "/media/hdb5/Eigene Dateien/Mozilla/Moz-shared-Profile/News/news.arcor.de.rc");

user_pref("mail.server.server4.newsrc.file-rel", "[ProfD]../../../../../media/hdb5/Eigene Dateien/Mozilla/Moz-shared-Profile/News/news.arcor.de.rc");

In my SM 2 profile's prefs.js I have:
user_pref("mail.server.server4.directory", "/home/jiha/.mozilla.org/seamonkey/960prn29.default/News/news.arcor.de");

user_pref("mail.server.server4.directory-rel", "[ProfD]News/news.arcor.de");

user_pref("mail.server.server4.newsrc.file", "/home/jiha/.mozilla.org/seamonkey/960prn29.default/News/news.arcor.de.rc");

user_pref("mail.server.server4.newsrc.file-rel", "[ProfD]../../../../../media/hdb5/Eigene Dateien/Mozilla/Moz-shared-Profile/News/news.arcor.de.rc");

There are no user_pref("mail.root.nntp", xxx); or user_pref("mail.root.nntp-rel", xxx); in the new profile.

Comment 1

[Mark Banner (:standard8)]

I hope to take a look at this soon. Do you know if there is anything like this for mail server prefs? or is it just news servers?

Comment 2

[Jürgen 'JiHa' Harter]

(In reply to comment #1)
> I hope to take a look at this soon. Do you know if there is anything like this
> for mail server prefs? or is it just news servers?
> 

As far as I can see this is a news issue only.
My IMAP, POP3 and local accounts were migrated properly.

(In reply to comment #0)
In between I added some news servers to my profile and now I can see
user_pref("mail.newsrc_root-rel", "[ProfD]News"); and
user_pref("mail.root.nntp-rel", "[ProfD]News");

So the pref still seems to be valid. It just was not migrated.

Comment 3

[WADA:World Anti-bad-Duping Agency]

I have following user modified entries in my prefs.js, because I use different Mail directory from one in profile and I want to set my mail directory for added accounts automatically.
Mark, will this special case easily be supported by migration?

> user_pref("mail.newsrc_root", "C:\\wada\\MAIL-NEWS\\News");
> user_pref("mail.newsrc_root-rel", "[ProfD]../../../../../../../../C:/wada/MAIL-NEWS/News");
> user_pref("mail.root.imap", "C:\\wada\\MAIL-NEWS\\ImapMail");
> user_pref("mail.root.imap-rel", "[ProfD]../../../../../../../../C:/wada/MAIL-NEWS/ImapMail");
> user_pref("mail.root.nntp", "C:\\wada\\MAIL-NEWS\\News");
> user_pref("mail.root.nntp-rel", "[ProfD]../../../../../../../../C:/wada/MAIL-NEWS/News");
> user_pref("mail.root.none", "C:\\wada\\MAIL-NEWS\\Mail");
> user_pref("mail.root.none-rel", "[ProfD]../../../../../../../../C:/wada/MAIL-NEWS/Mail");
> user_pref("mail.root.pop3", "C:\\wada\\MAIL-NEWS\\Mail");
> user_pref("mail.root.pop3-rel", "[ProfD]../../../../../../../../C:/wada/MAIL-NEWS/Mail");

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> Mark, will this special case easily be supported by migration?

Easily - maybe. I've got an idea of how to fix this but haven't actually tried doing it yet, but even if it isn't easy, it needs fixing anyway.

Comment 6

[Ian Neal]

How common is this problem? Would it impact many users? It would be good to get in for a1 but no patch at the moment so tempted to deny for a1

Comment 7

[Ian Neal]

Denying for 2.0a1 as no patch but it is something we want for 2.0. Adding relnote keyword.

Comment 8

[Ian Neal]

Could you try with a current nightly and see if you still have a problem as a patch has recently landed that could fix this.

Comment 9

[Robert Kaiser]

mcsmurf says that this is very probably fixed by bug 452465, so canceling the blocking flag and removing keywords and whiteboard that get obsoleted by that if this is true.

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> will this special case easily be supported by migration?
> 
> > user_pref("mail.newsrc_root", "C:\\wada\\MAIL-NEWS\\News");
> > user_pref("mail.newsrc_root-rel", "[ProfD]../../../../../../../../C:/wada/MAIL-NEWS/News");

Ftr, see bug 555625 about an issue with such rel-paths.

Comment 11

[Robert Kaiser]

I can't tell from current comments if this still applies to current nightlies (bug 555625 may surely play into this but without testing, I can't tell), so canceling wanted request.