382939 - [suiterunner] Profile migration does not migrate "forms never saved" in form manager

Status: RESOLVED WONTFIX

(SeaMonkey :: Startup & Profiles, defect)

Description

[Sven Grull]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070527 SeaMonkey/1.5a
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070527 SeaMonkey/1.5a

suiterunner win zip build 2007053106

Migrating from SeaMonkey 1.5 to suiterunner the sites with "forms never saved" in form manager are not carried over to suiterunner.

Reproducible: Always

Comment 1

[Mark Banner (:standard8)]

I've just happened to look at http://kb.mozillazine.org/Profile_folder_-_SeaMonkey, it appears we need to migrate URL.tbl for this.

Comment 2

[Mark Banner (:standard8)]

I've just confirmed it, URL.tbl is the file we're not migrating.

I'll come up with a fix for this in a few days once I've finished off a patch that reworks some of the string stuff in the migrator (will be attached to bug 329744 tonight).

Comment 3

[Mark Banner (:standard8)]

Attachment: The fix

Adds copying of the URL.tbl file which contains the site data for which we never save information.

Comment 4

[[e-mail]]

Comment on attachment 269282 [details] [diff] [review]
The fix

How does this relate to satchel (if at all)?

Comment 5

[Sven Grull]

(In reply to comment #4)
> How does this relate to satchel (if at all)?

It seems that url.tbl is converted to satchel data style when starting suiterunner for the first time as I can't find it in my profile anymore but the entries in form manager are still there.

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> (In reply to comment #4)
> > How does this relate to satchel (if at all)?
> 
> It seems that url.tbl is converted to satchel data style when starting
> suiterunner for the first time as I can't find it in my profile anymore but the
> entries in form manager are still there.
> 
Hmm, well given we're not actually using satchel yet that's a bit strange.

I think I need to look into this a bit more.

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #4)
> (From update of attachment 269282 [details] [diff] [review])
> How does this relate to satchel (if at all)?

AFAICT satchel doesn't have a way to not keep form details for particular servers, so enabling this would just mean keeping wallet working on migration. If you want to hold this off until the first release and see if we have satchel or wallet in place at the time, I'm happy for that.

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > How does this relate to satchel (if at all)?
> > 
> > It seems that url.tbl is converted to satchel data style when starting
> > suiterunner for the first time as I can't find it in my profile anymore but the
> > entries in form manager are still there.
> > 
> Hmm, well given we're not actually using satchel yet that's a bit strange.
> 
> I think I need to look into this a bit more.
> 

Strange, it stayed there for me on linux.

Comment 8

[Sven Grull]

Uh... sorry... I mixed up some checkins and didn't realize that this fix wasn't checked in and so my url.tbl was never copied. So it seems that the list of sites "forms never saved" was not fixed by this bug. 
Could it be that some changes in bug 329744 cleaned up handling of the ????????.s file? Because as I now realized in this file my list with sites "forms never saved" is stored and now transfered when I start migration from sm1.5 to suiterunner.

Comment 9

[[e-mail]]

Comment on attachment 269282 [details] [diff] [review]
The fix

It seems unlikely that we'll use wallet for formfill by 2.0

Comment 10

[Mark Banner (:standard8)]

We've now migrated to satchel (bug 304309 - and hence no longer using wallet for form fill), so we no longer need to fix this bug as the new satchel doesn't have a list of forms never saved. Therefore marking as wontfix.