382951 - [proto] new event dialog should use ATTACH to link to documents

Status: VERIFIED DUPLICATE of bug 319909

(Calendar :: General, defect)

Description

[Daniel Boelzle [:dbo]]

Regarding a discussion about URL vs. ATTACH on ietf-calsify (http://lists.osafoundation.org/pipermail/ietf-calsify/2007-May/001687.html), we should use ATTACH properties instead of setting the URL property of a component to link to documents. This bug is blocked by proper support for attachments (bug 319909).

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Oops, sorry, my bad, returning to the right component, awfully sorry about stomping your target milestone, please send hatemail to this address :(

Comment 2

[Daniel Boelzle [:dbo]]

Being conform with RFC 2445, this should be fixed. Volunteers wanted!

Comment 3

[Fred Jendrzejewski]

Hello, i tried some options, but any of them wasn't really satisfing:
1.) just changing from url to attach isn't nice. It isn't really good to set just the file url for exports laterly.
2.) setting a data - url is even uglier as you can't change your file anymore.
3.) setting files and urls as nsIMsgAttachments fails, as item.attachments can't be set.
As i work-around i'd like to propose the following ?
- Setting the attach property to the file url
- converting this url in a data url in the export

Comment 4

[Bernard Desruisseaux]

Fred,

No need to use data URL.  iCalendar allows you to specify inline attachments.
Look at the example here:

http://tools.ietf.org/html/rfc2445#section-4.1.3

Thanks,
Bernard

Comment 5

[Fred Jendrzejewski]

I looked a little bit more over the code and the change can't be done without the fix of bug 319909 .
We also discussed here : http://bugzilla.spicebird.org/show_bug.cgi?id=606

The last comment shows, why i stopped working now.
To allow the ATTACH property we need to have the CalAttachment class and this class has to change the url to an base64 encoded string, the same holds for the import.
I am new in "real" development work, so i thought, that this could be a little bit to hard for me for now.

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Fixed by bug 319909, attaching files is bug 168680.