383080 - add -moz-image-region reftest

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert Kaiser]

Attachment: zip of files for -moz-image-region test

When I asked on #developers if |-moz-image-region: rect(0px, 1px, 1px, 0px);| would result in a 1x1 or 2x2 image being used, bsmedberg replied with "could you write up a reftest for that?"

So, I sat down and did one. I'm not sure where exactly to add this test though - and I couldn't actually run it as a real reftest yet.

Note that -moz-image-region is supposed to be XUL only, so I did this as XUL files.

Comment 1

[Robert Kaiser]

OK, I at least did run the reftest locally now and it passes as it should.

Still, I don't know what directory/list to add this reftest to, does anyone have a good idea?

Comment 2

[Jeff Walden [:Waldo]]

I'll suggest a new directory named css-extensions, but I don't think it matters all that much.

Comment 3

[Robert Kaiser]

Attachment: add test in new css-extensions/ dir

As proposed by jwalden, this adds the test into a new css-extensions/ directory.
Along with the text-format files included in the patch, it also needs the two PNGs from jar:https://bugzilla.mozilla.org/attachment.cgi?id=267083!/ added to that dir.

Who can review this so I can get it in?

Comment 4

[Robert Kaiser]

OK, just as a reference, I did run a current trunk build with the reftest in this new dir and correctly get this (both when running the dir alone and the full set):

REFTEST PASS: file:///mnt/mozilla/src/mozilla/layout/reftests/css-extensions/image-region.xul

Comment 5

[Robert Kaiser]

Comment on attachment 272226 [details] [diff] [review]
add test in new css-extensions/ dir

Requesting review. This adds a reftest for our CSS extension of -moz-image-region.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think css-extensions is a good name for a reftest subdir. I would call it moz-image-region or something.

Comment 7

[Robert Kaiser]

Attachment: add test in new image-region/ dir

OK, per IRC request from roc, re-requesting review on new patch with image-region/ directory

Comment 8

[Robert Kaiser]

Checked in.