Closed Bug 383080 Opened 14 years ago Closed 14 years ago

add -moz-image-region reftest

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: kairo, Assigned: kairo)

Details

Attachments

(1 file, 2 obsolete files)

When I asked on #developers if |-moz-image-region: rect(0px, 1px, 1px, 0px);| would result in a 1x1 or 2x2 image being used, bsmedberg replied with "could you write up a reftest for that?"

So, I sat down and did one. I'm not sure where exactly to add this test though - and I couldn't actually run it as a real reftest yet.

Note that -moz-image-region is supposed to be XUL only, so I did this as XUL files.
OK, I at least did run the reftest locally now and it passes as it should.

Still, I don't know what directory/list to add this reftest to, does anyone have a good idea?
I'll suggest a new directory named css-extensions, but I don't think it matters all that much.
As proposed by jwalden, this adds the test into a new css-extensions/ directory.
Along with the text-format files included in the patch, it also needs the two PNGs from jar:https://bugzilla.mozilla.org/attachment.cgi?id=267083!/ added to that dir.

Who can review this so I can get it in?
Assignee: nobody → kairo
Attachment #267083 - Attachment is obsolete: true
Status: NEW → ASSIGNED
OK, just as a reference, I did run a current trunk build with the reftest in this new dir and correctly get this (both when running the dir alone and the full set):

REFTEST PASS: file:///mnt/mozilla/src/mozilla/layout/reftests/css-extensions/image-region.xul
Comment on attachment 272226 [details] [diff] [review]
add test in new css-extensions/ dir

Requesting review. This adds a reftest for our CSS extension of -moz-image-region.
Attachment #272226 - Flags: review?(roc)
I don't think css-extensions is a good name for a reftest subdir. I would call it moz-image-region or something.
OK, per IRC request from roc, re-requesting review on new patch with image-region/ directory
Attachment #272226 - Attachment is obsolete: true
Attachment #275351 - Flags: review?(roc)
Attachment #272226 - Flags: review?(roc)
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.