38319 - Hitting Enter to commit Ja chars to subject field makes cusor jump to mail body

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P3)

Description

[ji]

Build: Win32 2000-05-05-13 commercial build

On the mail compose window, in the subject field, when entering Japanese
characters, normaly hitting Enter will commit the Ja chars to the input field.
But now hitting Enter not only commits the Ja chars to the subject field, it
also makes the cursor jump to the mail body.

Steps of reproduce:
1. Launch mail.
2. Bring up mail compose window.
3. In the subject field, turn on Japanese IME and enter a Ja character and
   hit Enter to commit.
   You'll see the Ja char you typed is committed to the subject field, and
   the cursor also jumps to mail body input area.

It might be related to bug 35356.

Comment 1

[nhottanscp]

IME issue, reassign to ftang.

Comment 2

[Frank Tang]

can someone tell me which XUL is that one for the mail composition ?

Comment 3

[nhottanscp]

mailnews/compose/resources/content/messengercompose.xul

Comment 4

[Frank Tang]

This is a typical misuage of keyup/keydown for keypress issue.
We have same problem on url bar before.
The problem is in here
mailnews/compose/resources/content/messengercompose.xul
421                                                 
onkeyup="SetComposeWindowTitle(event.which);
422                                                          if (event.which == 
13)
423                                                             
contentWindow.focus();"
424                                                 onkeypress="if (event.which 
== 9)
425                                                                 if 
(event.shiftKey == false) {
426                                                                     
contentWindow.focus();
427                                                                     
event.preventDefault();
428                                                                 }"

you should check the if (event.which == 13) also in keypress but not keyup. The 
reason is IME may hit enter as intermediate process of typing a Japanese, in 
that case, it will generate keyup/keydown 13 but not keypress 13.

Also, probably we should also fix 
mailnews/compose/resources/content/addressingWidgetOverlay.xul

 71                                                                                         
onkeyup="if (event.which == 13) awReturnHit(this);"
 72                                                                                         
onkeydown="if (event.which == 9) {awTabFromRecipient(this, event);}"

I think both should be in keypress but not keyup/keydown

reassign to ducarroz since he own both file (shown on cvsblame)
ducarroz, can you change them to keypress ? Let me know if you have other 
concern.

Comment 5

[Frank Tang]

Also, please change  /xpfe/components/autocomplete/test/autocomplete_test.xul, 
line 128  so wrong code won't propogate. Thanks

Comment 6

[Jean-Francois Ducarroz]

Fixed and checcked in

Comment 7

[Katsuhiko Momoi]

** Checked with 5/9 Win32, Mac and Linux build **

This problem is fixed in the Linux build above but not on Windows or Mac build.

On Windows/Mac, the caret moves to the next address field when the CR is pressed to
commit. . (Note that in Subject field it works as intended).

Comment 8

[Katsuhiko Momoi]

Re-opened for Win and Mac.

Comment 9

[Jean-Francois Ducarroz]

momoi, this bug is only for the subject field. I have another bug for the addressing widget case.  I have fixed only 
the subject case! Close it again.

Comment 10

[Katsuhiko Momoi]

Sorry, J-F. I thought this was my bug. This is in fact Xianglan's bug. 
I didn't pay close enough attention on the subject line. 
I'm sedning this over to ji for verification.
Sorry!

Comment 11

[ji]

Verified as fixed with win32 2000050909 build