383202 - <junklog.html> entries read "moved" even when messages are not actually moved

Status: NEW

(MailNews Core :: Filters, defect)

Description

[Serge Gautherie (:sgautherie)]

From bug 196732 comment 96
{{
 Serge Gautherie   2007-05-31 17:17:56 PDT

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070529
SeaMonkey/1.5a] (nightly) (W2Ksp4)

Not-moved (due to later failure) messages are marked as "moved" in <junklog.html>,
[
Detected junk message from &quot;Edi howden&quot; &lt;[e-mail]&gt;
- When overridden in a descendant class, gets or sets the content length of
data being received. at 26/05/2007 23:52:47
moved message id = 000b01c79fe0$3283d620$128a1552@mitch to
mailbox://zyx@z.y.z/Junk
]
}}

I traced it to
<http://lxr.mozilla.org/mozilla/source/mailnews/imap/src/nsImapMailFolder.cpp#7727>
{{
7727     rv = spamSettings->LogJunkHit(msgHdr, willMoveMessage);

7744     PlaybackCoalescedOperations();
}}

As I understand this code,
*<junklog.html> is written as soon as a junk message is detected;
*but the actual move(s) is performed later, in a "batch" mode, which may fail (for reasons we don't care in the bug).

My point:
*The "Detected junk message" line is always welcomed.
*In case of failure, the "moved message ... to ..." line could be either
 *replaced by a "*not* moved ..."
 *or followed by an error warning of some kind.

*****

There is some +/- similar code at
<http://lxr.mozilla.org/mozilla/source/mailnews/local/src/nsLocalMailFolder.cpp#3451>
{{
3451     rv = spamSettings->LogJunkHit(msgHdr, willMoveMessage);

3480           rv = copySvc->CopyMessages(this, messages, folder, PR_TRUE,
}}

I don't know if it has the same "bug" or not.

*****

The actual writing happens at
<http://lxr.mozilla.org/mozilla/source/mailnews/base/src/nsSpamSettings.cpp>
{{
553 NS_IMETHODIMP nsSpamSettings::LogJunkHit(nsIMsgDBHdr *aMsgHdr, PRBool aMoveMessage)

639 NS_IMETHODIMP nsSpamSettings::LogJunkString(const char *string)
}}

All these code are shared between Thunderbird and SeaMonkey.

Comment 1

[buovjaga]

Code blocks are unchanged (just on different lines, substitute dxr for lxr).