383204 - Sidebar has wrong label after restoring browser to a new session

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[cmtalbert]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a6pre) Gecko/20070604 Minefield/3.0a6pre
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a6pre) Gecko/20070604 Minefield/3.0a6pre

The sidebar label always opens to history data, but does not update the label to reflect this.  So, you get the history items in the sidebar window, but the label still says "Bookmarks".

Reproducible: Always

Steps to Reproduce:
1. Start the browser, open bookmarks in the sidebar
2. kill -9 the browswer
3. Start the browser, choose "Start a New Session"
4. Note that the sidebar's label does not match its data.


Actual Results:  
Label == Bookmarks while the Data == History.

Expected Results:  
The label and the data will agree, AND whichever window was opened before the crash will be restored after the crash.  For example, if the Bookmarks sidebar was opened, then the Bookmarks sidebar should be opened on restart.

This does not happen if you choose "Restore Session".  Also, this cannot be tested on windows or linux because the browser does NOT reopen the sidebar on windows and linux when "starting a new session" from a crash (which is a different bug).

Comment 1

[cmtalbert]

Going to ask for blocking on this because it is just completely broken UI code here, and could be misleading/confusing to a novice user.

Comment 2

[cmtalbert]

Attachment: picture of the problem

Comment 3

[Simon Bünzli]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/2007060304 Minefield/3.0a6pre

I'm not able to reproduce your issue.

I guess it's due to a broken localstore.rdf though (from which the persistent properties of new windows are taken and which only rarely gets saved - mostly at shutdown). If you can reproduce the issue again, please attach that file from right after the crash (i.e. make copies before starting Firefox again).

And since this is about starting a new session (and not _restoring_ a saved one)
-> Firefox / General

Comment 5

[:Gavin Sharp [email: [e-mail]]]

This isn't a blocker bug (the sidebar label is hardly a critical piece of the UI, and there's no functional effect).

Comment 6

[Simon Bünzli]

Clint: Have you ever been able to reproduce this issue again? If so, could you please attach localstore.rdf (and maybe sessionstore.js as well) in order to help debugging (make sure both files don't contain privacy sensitive data)?

Comment 7

[Simon Bünzli]

Why ever this was moved back to Session Restore - this should still be a localstore.rdf issue. -> Firefox:General

Comment 8

[cmtalbert]

No, I can't reproduce this anymore. Sorry this bug fell off my radar.