Closed Bug 383209 Opened 15 years ago Closed 15 years ago

Clear Private Data fails to clear stored passwords

Categories

(Toolkit :: Password Manager, defect)

defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla1.9alpha6

People

(Reporter: zach, Assigned: Dolske)

Details

(Keywords: privacy, regression)

Attachments

(1 file)

Steps to reproduce:
1. Visit various login forms, store passwords in password manager
2. Tools->Clear Private Data
3. Select the option to clear saved passwords
4. Clear Private Data Now
5. Open Preferences->Security->Show Passwords

Note that the saved passwords are not cleared and are still in the Password Manager list. Clear Private Data does clear history and other data, so the feature as a whole seems to be working, just not the clearing of passwords. 

This seems pretty critical to me, as users think their stored passwords have been deleted, but we silently fail to do so.
Flags: blocking-firefox3?
Keywords: relnote
Keywords: privacy
Version: unspecified → Trunk
I've narrowed down a regression range:

2007-05-15-04: Works properly
2007-05-16-04: Exhibits bug
Yes, that's almost certainly the cause.
Flags: blocking-firefox3? → blocking-firefox3+
Target Milestone: --- → Firefox 3 alpha6
moving out, needs to make b1, please make sure this is covered in the a6 release notes (I think Deb's doing those)
Target Milestone: Firefox 3 alpha6 → Firefox 3 beta1
This is a fairly trivial fix.

[I'll probably need to post an updated patch, with testcase, to get this to cleanly apply. It's on top of a couple other patches in my tree that should be landing today.]
Attachment #270041 - Flags: review?(gavin.sharp)
Attachment #270041 - Flags: review?(gavin.sharp) → review+
mozilla/toolkit/components/passwordmgr/public/nsILoginManager.idl 	1.2
mozilla/toolkit/components/passwordmgr/public/nsILoginManagerStorage.idl 1.3
mozilla/toolkit/components/passwordmgr/src/nsLoginManager.js 	1.8
mozilla/toolkit/components/passwordmgr/src/storage-Legacy.js 	1.8
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 3 beta1 → Firefox 3 alpha6
Hmm, since the implementation changed, shouldn't the iid have changed as well?
http://lxr.mozilla.org/mozilla/source/toolkit/components/passwordmgr/src/nsLoginManager.js#1356
(In reply to comment #7)
> Hmm, since the implementation changed, shouldn't the iid have changed as well?

The iid changes when the interface changes, not the implementation. If I had changed the interface to match the implementation, then the iid would have been updated.
Verified fix on Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6) Gecko/20070629 GranParadiso/3.0a6.   Clear private data is clearing passwords now. 
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.