383275 - disabling JS disables localizing phishing EULAs

Status: VERIFIED INVALID

(Toolkit :: Safe Browsing, defect)

Description

[Marek Stępień [:marcoos, inactive]]

The fallback phishing protection EULA is not localizable:
http://lxr.mozilla.org/mozilla/source/browser/components/preferences/phishEULA.xhtml

Steps to reproduce:
1) Get a non-en-US build of Firefox
2) Turn off JavaScript (so that the fallback URL is used in the next step)
3) Select Firefox > Preferences > Security > [v] Ask [Google]... to open the EULA window

Expected results:
Phishing EULA in a language other than American English

Actual results:
Phishing EULA in American English

We do have the strings translated, so it should be just a matter of adding a dtd.

Comment 1

[Axel Hecht [:Pike]]

As per bug 350422, it is intended behavior that the fallback is not localizable. Legalese and licensing and all.

What puzzles me is that you can trigger this with disabling js, that sounds like a bug. I can't reproduce this ad-hoc, can you make sure that that's really the case?

Comment 2

[Marek Stępień [:marcoos, inactive]]

It seems so. We had reports about this in the Polish community forum and I reproduced it with 2.0.0.4 on Mac.

Here's my screencast:
http://www.screencast-o-matic.com/watch/ci1hfgl4

Comment 3

[Axel Hecht [:Pike]]

Resummarizing.

I'm a tad clueless how that could happen. Could you check with DOMI that it's really us triggering the fallback and not google having problems on the server with, for example, using js in the entry page to redirect to localizations or something?

Comment 4

[Marek Stępień [:marcoos, inactive]]

This is not the fallback page, it turns out.

It's Google using JavaScript to switch the language at their phishing EULA page:
http://www.google.com/tools/firefox/firefox_privacy.html?hl=pl

This should be done server-side, imho.

Comment 5

[u251854]

Is it still necessary to keep this bug open?
I don't see the option to enable sending URLs to Google in the preferences UI. Is it temporary or has it been completely removed?

Comment 6

[Johnathan Nightingale [:johnath]]

Yes, the code supporting this pref and behaviour has been removed, so I will mark this bug as INVALID.

Comment 7

[Marek Stępień [:marcoos, inactive]]

Technically, it might still be valid for Firefox 2.0.0.x users, and the Google guys might still want to fix that on their side.

As this feature is reportedly not widely used (as mentioned in some other bug), I'm marking this verified.