383296 - ASSERTION: can't mark frame dirty during reflow: '!mIsReflowing' in nsPresShell.cpp

Status: RESOLVED DUPLICATE of bug 381285

(Core :: SVG, defect)

Description

[Jonathan Watt [:jwatt]]

Attachment: testcase that triggers the assertion when the window is resized

Since bug 369827 added a RequestReflow call to nsSVGForeignObjectFrame::NotifyCanvasTMChanged we've been getting the following assertion:

  ASSERTION: can't mark frame dirty during reflow: '!mIsReflowing'

in nsPresShell.cpp due to the following stack.

  PresShell::FrameNeedsReflow
  nsSVGForeignObjectFrame::RequestReflow
  nsSVGForeignObjectFrame::NotifyCanvasTMChanged
  nsSVGOuterSVGFrame::NotifyViewportChange
  nsSVGOuterSVGFrame::Reflow

I'm not sure how bad this is. Since PresShell::FrameNeedsReflow doesn't seem to return, from a cursory look it would seem the foreignObject's descendants will still be reflowed. I've still to consider this bug in detail though.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Isn't this bug 381285?

And it's somewhat bad -- you'll confuse the presshell as to what should be reflowed; things might end up not getting reflowed properly in the future (e.g. if you do another resize).

Comment 2

[Boris Zbarsky [:bzbarsky]]

Oh, and note that bug 381285 has a suggestion for fixing this.

Comment 3

[Jonathan Watt [:jwatt]]

Ah, yeah, you're right. Thanks bz.