nsIScriptEventManager is used only by activex component. If that
component wants to support <script for="foo" event="bar"> it should
implement the functionality outside content/. Adding some hooks to
script element handling may be needed.
Created attachment 520597 [details] [diff] [review]
Comment on attachment 520597 [details] [diff] [review]
Olli, feel free to send back my way if needed, but you're a better reviewer for this, I think.
The patch seems to remove the checks for for and event attributes.
Those need still special handling
Benjamin, how alive is http://mxr.mozilla.org/mozilla-central/source/embedding/browser/activex/src/plugin/ ?
I plan on removing it, I think there's a reviewed patch somewhere even.
Matheus, would be great if you could add back those for/event checks and
write some tests for for/event attributes.
Created attachment 541645 [details] [diff] [review]
Comment on attachment 541645 [details] [diff] [review]
Could you please add some tests for 'for' and 'event' attributes.
Created attachment 542536 [details] [diff] [review]
Really stupid test, but I didn't know of any better way to test this.
Matheus, can I submit your test to the HTML test suite? (Licensed under the W3C test suite license <http://www.w3.org/Consortium/Legal/2008/04-testsuite-license.html> and 3-clause BSD <http://www.w3.org/Consortium/Legal/2008/03-bsd-license.html>.)
(In reply to comment #10)
> Matheus, can I submit your test to the HTML test suite?
Created attachment 543622 [details] [diff] [review]
Turns out that NS_ERROR_DOM_NOT_SUPPORTED_ERR wasn't correct.
Comment on attachment 543622 [details] [diff] [review]
Verified fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
Build ID: 20110902161802
The bug was verified using the test referred in the link from the above comment (test_bug383383_2.xhtml), which has passed.