Remove nsIScriptEventManager and nsIScriptEventHandler

VERIFIED FIXED in mozilla7

Status

()

Core
DOM
--
enhancement
VERIFIED FIXED
10 years ago
6 years ago

People

(Reporter: smaug, Assigned: Matheus Kerschbaum)

Tracking

({dev-doc-complete})

Trunk
mozilla7
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

10 years ago
nsIScriptEventManager is used only by activex component. If that
component wants to support <script for="foo" event="bar"> it should
implement the functionality outside content/. Adding some hooks to
script element handling may be needed.
(Assignee)

Comment 1

6 years ago
Created attachment 520597 [details] [diff] [review]
patch
Attachment #520597 - Flags: review?(bzbarsky)
Comment on attachment 520597 [details] [diff] [review]
patch

Olli, feel free to send back my way if needed, but you're a better reviewer for this, I think.
Attachment #520597 - Flags: review?(bzbarsky) → review?(Olli.Pettay)
(Reporter)

Comment 3

6 years ago
The patch seems to remove the checks for for and event attributes.
Those need still special handling

http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#script
(Reporter)

Comment 4

6 years ago
Benjamin, how alive is http://mxr.mozilla.org/mozilla-central/source/embedding/browser/activex/src/plugin/ ?
I plan on removing it, I think there's a reviewed patch somewhere even.
(Reporter)

Comment 6

6 years ago
Matheus, would be great if you could add back those for/event checks and
write some tests for for/event attributes.
(Reporter)

Updated

6 years ago
Attachment #520597 - Flags: review?(Olli.Pettay) → review-
(Assignee)

Updated

6 years ago
Depends on: 662023
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86 → All
(Assignee)

Comment 7

6 years ago
Created attachment 541645 [details] [diff] [review]
patch v2
Attachment #520597 - Attachment is obsolete: true
Attachment #541645 - Flags: review?(Olli.Pettay)
(Reporter)

Comment 8

6 years ago
Comment on attachment 541645 [details] [diff] [review]
patch v2

Could you please add some tests for 'for' and 'event' attributes.
Attachment #541645 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 9

6 years ago
Created attachment 542536 [details] [diff] [review]
test

Really stupid test, but I didn't know of any better way to test this.
Attachment #542536 - Flags: review?(Olli.Pettay)
(Reporter)

Updated

6 years ago
Attachment #542536 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/abb75fbb583b
http://hg.mozilla.org/integration/mozilla-inbound/rev/d8f6acb58422

Matheus, can I submit your test to the HTML test suite? (Licensed under the W3C test suite license <http://www.w3.org/Consortium/Legal/2008/04-testsuite-license.html> and 3-clause BSD <http://www.w3.org/Consortium/Legal/2008/03-bsd-license.html>.)
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
(Assignee)

Comment 11

6 years ago
(In reply to comment #10)
> Matheus, can I submit your test to the HTML test suite?

Sure.
Keywords: dev-doc-needed
http://hg.mozilla.org/mozilla-central/rev/abb75fbb583b
http://hg.mozilla.org/mozilla-central/rev/d8f6acb58422
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Created attachment 543622 [details] [diff] [review]
Followup

Turns out that NS_ERROR_DOM_NOT_SUPPORTED_ERR wasn't correct.
Attachment #543622 - Flags: review?(Olli.Pettay)
(Reporter)

Updated

6 years ago
Attachment #543622 - Flags: review?(Olli.Pettay) → review+

Updated

6 years ago
Keywords: dev-doc-needed → dev-doc-complete
Comment on attachment 543622 [details] [diff] [review]
Followup

http://hg.mozilla.org/mozilla-central/rev/b7f03b37cf0c

Updated

6 years ago
Whiteboard: [inbound]

Comment 15

6 years ago
Verified fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
Build ID: 20110902161802

The bug was verified using the test referred in the link from the above comment (test_bug383383_2.xhtml), which has passed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.