Closed Bug 383383 Opened 18 years ago Closed 14 years ago

Remove nsIScriptEventManager and nsIScriptEventHandler

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla7

People

(Reporter: smaug, Assigned: matjk7)

References

Details

(Keywords: dev-doc-complete)

Attachments

(3 files, 1 obsolete file)

patch v2
33.46 KB, patch
smaug
: review+
Details | Diff | Splinter Review
test
1.97 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Followup
1.93 KB, patch
smaug
: review+
Details | Diff | Splinter Review
nsIScriptEventManager is used only by activex component. If that component wants to support <script for="foo" event="bar"> it should implement the functionality outside content/. Adding some hooks to script element handling may be needed.
Attached patch patch (obsolete) — — Splinter Review
Attachment #520597 - Flags: review?(bzbarsky)
Comment on attachment 520597 [details] [diff] [review] patch Olli, feel free to send back my way if needed, but you're a better reviewer for this, I think.
Attachment #520597 - Flags: review?(bzbarsky) → review?(Olli.Pettay)
The patch seems to remove the checks for for and event attributes. Those need still special handling http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting-1.html#script
I plan on removing it, I think there's a reviewed patch somewhere even.
Matheus, would be great if you could add back those for/event checks and write some tests for for/event attributes.
Attachment #520597 - Flags: review?(Olli.Pettay) → review-
Depends on: 662023
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86 → All
Attached patch patch v2 — — Splinter Review
Attachment #520597 - Attachment is obsolete: true
Attachment #541645 - Flags: review?(Olli.Pettay)
Comment on attachment 541645 [details] [diff] [review] patch v2 Could you please add some tests for 'for' and 'event' attributes.
Attachment #541645 - Flags: review?(Olli.Pettay) → review+
Attached patch test — — Splinter Review
Really stupid test, but I didn't know of any better way to test this.
Attachment #542536 - Flags: review?(Olli.Pettay)
Attachment #542536 - Flags: review?(Olli.Pettay) → review+
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/abb75fbb583b http://hg.mozilla.org/integration/mozilla-inbound/rev/d8f6acb58422 Matheus, can I submit your test to the HTML test suite? (Licensed under the W3C test suite license <http://www.w3.org/Consortium/Legal/2008/04-testsuite-license.html> and 3-clause BSD <http://www.w3.org/Consortium/Legal/2008/03-bsd-license.html>.)
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
(In reply to comment #10) > Matheus, can I submit your test to the HTML test suite? Sure.
Keywords: dev-doc-needed
http://hg.mozilla.org/mozilla-central/rev/abb75fbb583b http://hg.mozilla.org/mozilla-central/rev/d8f6acb58422
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attached patch Followup — — Splinter Review
Turns out that NS_ERROR_DOM_NOT_SUPPORTED_ERR wasn't correct.
Attachment #543622 - Flags: review?(Olli.Pettay)
Attachment #543622 - Flags: review?(Olli.Pettay) → review+
Keywords: dev-doc-needed → dev-doc-complete
Whiteboard: [inbound]
Verified fixed on: Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:7.0) Gecko/20100101 Firefox/7.0 Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0 Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0 Build ID: 20110902161802 The bug was verified using the test referred in the link from the above comment (test_bug383383_2.xhtml), which has passed.
Status: RESOLVED → VERIFIED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: