383469 - Switch to xcodeproj project

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

We really need to get off the old project file; filing so it's not just something I occasionally remember to ask about.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Stuart is doing this; among other things, the autoimport process apparently makes a mess of stuff.

Comment 2

[Stuart Morgan]

Attachment: trunk project [landed]

This is the trunk version; I'd like to make sure this seems like a sane layout before doing the branch version the same way. Notes:
- I moved most settings into xcconfigs to prevent things like duplication across Camino and CaminoStatic.
- I created xcconfigs for the three build configurations and applied them at the project level rather than just setting them in the project settings, since a) I think it's easier to be able to look at the project settings and see what applies to everything globally, and b) we may want to diverge pref pane and Camino settings at some point, and this would make it easier to make new combination configs (e.g., PrefPaneDebug).
- I turned off prebinding, since it's deprecated for 10.4+
- The warning settings should be pretty close to what they were before, but there were some bizarre inconsistencies (lots of differences between debug and release) that I didn't keep. I'm planning to adjust our warnings over time anyway.
- This removes the Info-CaminoStatic.plist (the file removal isn't in the patch, since that's not very interesting to review), in favor of both Camino targets using the same plist
- I didn't worry too much about cleaning up the pref pane settings, since a lot of that will change once they aren't building core.

I need to test static still; I'll do that later today.

Comment 3

[Mark Mentovai]

Comment on attachment 272814 [details] [diff] [review]
trunk project [landed]

This looks mostly good to me, let me know when you've tested static and I'll give you your r+.  (Don't wait for it if I'm not around.)

Comment 4

[Mark Mentovai]

Comment on attachment 272814 [details] [diff] [review]
trunk project [landed]

r+ as discussed

Comment 5

[Stuart Morgan]

Comment on attachment 272814 [details] [diff] [review]
trunk project [landed]

Landed with the minor adjustments discussed on IRC and more actual file removals.

Keeping open for branch and the IB view project.

Comment 6

[Stuart Morgan]

Attachment: IB palette project

This is pretty much just a straight upgrade with the SDK/deployment removed per bug 387845 and the extra "Default" configuration ripped out.

Comment 7

[Stuart Morgan]

Attachment: Branch project

Branch version. The xcconfigs, makefile changes, etc. are all identical to the trunk, so this is just the project itself.

Comment 8

[Mark Mentovai]

Comment on attachment 272981 [details] [diff] [review]
Branch project

This is planned for MOZILLA_1_8_BRANCH but not CAMINO_1_5_BRANCH, right?

I'd be OK with this for 1.5 despite the philosophical "it's a stable branch" argument if it made maintenance easier, but I don't anticipate that project file will need many changes.  The real reason I bring this up is that we still have a 10.3 tinderbox building 1.5.

Comment 9

[Samuel Sidler (old account; do not CC)]

(In reply to comment #8)
> I'd be OK with this for 1.5 despite the philosophical "it's a stable branch"
> argument if it made maintenance easier, but I don't anticipate that project
> file will need many changes.  The real reason I bring this up is that we still
> have a 10.3 tinderbox building 1.5.

I'm not really okay with it, even if it does make maintenance easier. As long as we support 10.3, I think it's good to have a box building on 10.3 and running quick start-up tests. This won't be true for 1.6, but let's keep it around for 1.5.

Comment 10

[Stuart Morgan]

I wasn't planning on changing 1.5; project changes on our maintenance branches aren't that common.

Comment 11

[Stuart Morgan]

Branch project landed on MOZILLA_1_8_BRANCH, IBPalette project landed on trunk and MOZILLA_1_8_BRANCH.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Just for the record, smorgan checked in a change to the MOZILLA_1_8_BRANCH project to make it respect .mozconfig SDK/compiler/deployment target changes: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/camino/Camino.xcodeproj&command=DIFF_FRAMESET&file=project.pbxproj&rev1=1.2.2.1&rev2=1.2.2.2&root=/cvsroot

(It's not in contention, but while I'm commenting, as long as we have binus configured as-is, we have an available box that we can use, if needed, to run 10.3 smoketests on cb-x1-produced 1.6 builds remotely.  That's a good thing.)

Comment 13

[Hiro]

Build of Camino was tried. 
However, the following errors occur. 
Has 10.3 already ended the support with all branch?

make[4]: Entering directory `/Users/sek/Documents/mozilla-current/camino18/mozilla/camino/IBPalette'
NEXT_ROOT= /usr/bin/xcodebuild -project CaminoViewsPalette.xcodeproj -target All -configuration Deployment GCC_VERSION="3.3" SYMROOT=build SDKROOT="/Developer/SDKs/MacOSX10.3.0.sdk" MACOSX_DEPLOYMENT_TARGET="10.3" GCC_MODEL_TUNING= OPTIMIZATION_CFLAGS="-Os -pipe -mcpu=7400"
unknown option: -configuration
Usage: xcodebuild [-project <projectname>] [-activetarget] [-alltargets] [-target <targetname>]... [-activebuildstyle] [-buildstyle <buildstylename>] [-optionalbuildstyle <buildstylename>] [<buildsetting>=<value>]... [<buildaction>]...
       xcodebuild [-list]
make[4]: *** [libs] Error 1
make[4]: Leaving directory `/Users/sek/Documents/mozilla-current/camino18/mozilla/camino/IBPalette'
make[3]: *** [libs] Error 2


Mac OS X 10.3.9
MOZILLA_1_8_BRANCH  source

Comment 14

[Samuel Sidler (old account; do not CC)]

(In reply to comment #13)
> Build of Camino was tried. 
> However, the following errors occur. 
> Has 10.3 already ended the support with all branch?

<snip>

> Mac OS X 10.3.9
> MOZILLA_1_8_BRANCH  source

Trunk has dropped support for both building and running on 10.3. We opted to support running Camino on 10.3 on the branch, but building is limited to 10.4 now. Camino 1.6 will support 10.3, but you won't be able to build it on that platform.

Comment 15

[Stuart Morgan]

And to be clear about the reason: using a project file that was only editable using 10.3's developer tools when almost all of our development is done by 10.4 users was a huge problem, and has been slowing our development noticeably for quite a while. It's an unfortunate necessity of the strong tie between OS version and developer tools version in 10.3 and 10.4 and the fact that the project file format for Xcode is not compatible between the two versions.