383479 - Combobox dropdown scrollbar width no longer matches dropmarker width

Status: NEW

(Core :: Widget: Gtk, defect)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1)  Load this bug page
2)  Click on the "Component" combobox

EXPECTED RESULT: Scrollbar width is same as dropmarker, for pleasing visual effect.

ACTUAL RESULT: Scrollbar is much narrower

This is a regression from the native theming change -- the dropmarker size changed, but the scrollbar size is the same.

The problem is even worse if a theme other than "classic" is used; some otehr themes use narrower scrollbars.

I have not been able to locate a native GTK2 dropdown that has a scrollbar on the list, so no idea how those look.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

You can change any gtk2 drop-down to 'list mode' by sticking something like this in your ~/.gtkrc-2.0 file:

style "liststyle" { GtkComboBox::appears-as-list = 1 } class "*" style "liststyle"

And the result is that the drop-down's scrollbar is the same size as every gtk scrollbar, which is indeed thinner than the drop-down marker.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Well, it looks really really crappy.  I'd frankly rather have non-GTK styled comboboxes that look less crappy...  From my personal pov.

Comment 3

[Michael Ventnor]

I'm not seeing this. What theme are you using?

Comment 4

[Michael Ventnor]

Oh wait, no, sorry, I get what you mean.
Native GTK2 dropdown lists don't use a scrollbar, they have buttons at the top and bottom.  Dropdown lists aren't using native rendering, rather Gecko is making the list itself out of list items and a scrollbar.

We can't help the dropmarker size or the scrollbar size. It looks fine to me though...

Comment 5

[Boris Zbarsky [:bzbarsky]]

<shrug>.  It looks misaligned, basically.  Like the two things really should match up but someone just failed to do it.

Comment 6

[Michael Ventnor]

Definitely not a blocker IMO but I'll see what I can do. I might be able to manipulate borders like I did to buttons to get the correct size.

Comment 7

[Michael Ventnor]

bz, whats the WidgetType for the dropdown lists? Is it NS_THEME_MENUPOPUP?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think the combobox dropdown list is themed.

Comment 9

[Michael Ventnor]

(In reply to comment #8)
> I don't think the combobox dropdown list is themed.
> 

Its not themed and its much too difficult to make it themed based on our current XP widget implementation. In fact, are dropdown lists natively rendered on any platform? I seem to recall Josh showing off a dropdown list constructed in the exact same way (items with a scrollbar) on OSX.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah. This is probably more work than we want to take on at this point. For now it might be best to just turn off theming of comboboxes.

Comment 11

[Michael Ventnor]

(In reply to comment #10)
> Yeah. This is probably more work than we want to take on at this point. For now
> it might be best to just turn off theming of comboboxes.
> 

Why? OSX has native comboboxes but non-native dropdowns (I think).
Do you have a screenshot of OSX's behaviour?

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #11)
> Why? OSX has native comboboxes but non-native dropdowns (I think).

Yeah, but they look decent IMHO.

> Do you have a screenshot of OSX's behaviour?

I would, but my Mac decided to not take screenshots today.

Comment 13

[Boris Zbarsky [:bzbarsky]]

On the mac, the difference in width is about 1px -- there if you're looking for it, but doesn't jump out at you.  Over here on Linux, the difference is more like 4px, which is about 30% of the scrollbar width...

Comment 14

[Tuukka Tolvanen (sp3000)]

Attachment: clearlooks screenshot

meh, to me it looks better with the native theming -- with the olden style it's still off by a px or two depending on how you count so it just looks slightly broken; with native theming the two parts look plain different and don't disagree that badly imo. (dunno what's up with the extra black border on the right in both dropdowns) (hm, aren't comboboxes properly the ones you also can type into, hence "combined" dropdown/textinput?)

Comment 15

[Boris Zbarsky [:bzbarsky]]

Uh... That screenshot for the "old" version looks wrong.  That's not what it looked like when I last looked at it; someone has broken something.  We would want to fix that something, of course.

Comment 16

[Dão Gottwald [:dao]]

(In reply to comment #15)
> Uh... That screenshot for the "old" version looks wrong.  That's not what it
> looked like when I last looked at it;

But that's how it looks with Firefox 2, too.

Comment 17

[Boris Zbarsky [:bzbarsky]]

Yeah, there was a 1px error in Firefox 2.  We fixed it with the reflow branch landing.

Comment 18

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Not a blocker, though from your screenshot, I couldn't really tell which one looked "wrong" (I assumed you meant the first one).  The first one looks much better than the second to me, even with the scrollbar width issue.

Comment 19

[JP Rosevear [:jpr]]

Still an issue.

Comment 20

[Karl Tomlinson (:karlt)]

If we theme the dropmarker and the scrollbar (and we do I assume), then I expect their widths should come from the theme.  As comment 1 points out, these widths are different, so I don't know what could be improved there.

The black strips on the right and bottom make a bigger eyesore than the alignment issue.  They might be due to rounding issues as they are sometimes there and sometimes not, depending on the dropdown.  I see them on the Component dropdown, but the right strip is not there on the OS dropdown.  The default font dropdown in Firefox preferences doesn't have any black strips.  The black strips exist, or the right border is missing even on dropdowns without scrollbars.

Theming the borders of the dropdown could be an improvement.  I don't know how much work that would be (reading comment 9).

Comment 21

[Karl Tomlinson (:karlt)]

Accidentally changed the component.  Graphics wasn't right either.  Not sure that Widget: Gtk is either, but maybe.