383481 - Profile migration doesn't migrate userChrome.css

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1)  Start a suiterunner build
2)  Migrate an existing profile

EXPECTED RESULTS: userChrome.css migrated just like userContent.css.

ACTUAL RESULTS: userChrome.css not migrated.

Comment 1

[Mark Banner (:standard8)]

See http://groups.google.co.uk/group/mozilla.dev.apps.seamonkey/browse_thread/thread/9f29f96f2405f265/f3590151fca750cb#f3590151fca750cb for some discussion that there's been on this (its fairly early on in the threads).

I don't know if its 'dangerous' or not. I was copying what FF did when migrating from SM profiles and it doesn't copy userChrome.css either. Though that may be because its between two different apps.

Interesting the Phoenix -> FF migrator does copy userChrome.css.

Opinions? Its not a big change to do.

Comment 2

[[e-mail]]

(In reply to comment #1)
>Interesting the Phoenix -> FF migrator does copy userChrome.css.
So that would suggest that we should copy userChrome.css for SeaMonkey only.

Comment 3

[Robert Kaiser]

What we could perhaps do is copy it to a name like userChrome-migrated.css so that a user just needs to rename it back again, but doesn't need to manually copy it.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Migrating userChrome.css between vastly different UIs might not make sense because a lot of it won't apply.  So I can see why Phoenix -> FF copies while Mozilla -> FF does not.

If there is really a significant difference in the XUL (as Justin says), I suppose it might make sense to not migrate it based on the above criterion.  The real question is how likely the typical changes in userChrome are to migrate well.  I don't have an answer to that, in all honesty; the entirety of my userChrome.css is:

  * { font-size: 9pt ! important } 

Comment 5

[Felix Miata]

My experience with userChrome.css and Justin's newsgroup comment lead me to agree with Robert's comment 3 suggestion, except when copying from like kind, as from Mozilla Suite to SeaMonkey.

userChrome.css in my main SM profile on OS/2 is over 3k. I don't like the same font size applied everywhere. ;-)

Comment 6

[Mark Banner (:standard8)]

I'm going to take this and implement it for SeaMonkey only in the first instance. Thunderbird is up for discussion, though Robert's idea sounds interesting. Any other apps we don't have migrators for.

Comment 7

[Mark Banner (:standard8)]

Attachment: The fix v1

Copies userChrome.css for SeaMonkey only. Neil & I think that copying of userChrome.css isn't necessary for Thunderbird.

Comment 8

[[e-mail]]

Comment on attachment 274508 [details] [diff] [review]
The fix v1

I don't suppose it would save much to have a CopyUserSheet(char *) function that could copy content or chrome sheets?

Comment 9

[Mark Banner (:standard8)]

(In reply to comment #8)
> (From update of attachment 274508 [details] [diff] [review])
> I don't suppose it would save much to have a CopyUserSheet(char *) function
> that could copy content or chrome sheets?

We might save a bit. I'd have to add a bool as an argument as well so the chrome sheet could be selectively copied. Other than that we'd save defining two functions and probably be able to clone the nsIFiles rather than regenerating them.

Comment 10

[[e-mail]]

(In reply to comment #9)
>We might save a bit. I'd have to add a bool as an argument as well so the
>chrome sheet could be selectively copied. Other than that we'd save defining
>two functions and probably be able to clone the nsIFiles rather than
>regenerating them.
Actually I was thinking of something like this:
CopyUserSheet(FILE_NAME_USERCONTENT);
CopyUserSheet(FILE_NAME_USERCHROME);

Comment 11

[Mark Banner (:standard8)]

Attachment: Better patch

Better way as suggested by Neil -> reuse the same function.

Comment 12

[Mark Banner (:standard8)]

Patch checked in -> fixed.