Closed
Bug 383723
Opened 17 years ago
Closed 17 years ago
Clearing the sort filter in the Cookies dialog makes the data become unsorted and the selection is lost
Categories
(Firefox :: Settings UI, defect, P5)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 3 beta2
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
(Keywords: polish)
Attachments
(2 files)
3.29 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
3.29 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5) Gecko/20070606 GranParadiso/3.0a5 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5) Gecko/20070606 GranParadiso/3.0a5 Check out the following steps to reproduce the problem for a description. Reproducible: Always Steps to Reproduce: 1. Open Options, go to the Privacy section, and click the Show Cookies button. The Cookies dialog appears, and the focus is set to the filter text box. 2. Press Esc. The cookies sorted order by host name is lost. The selection is also lost. 3. Enter some filter, and then clear it. The same symptoms appear. Actual Results: The selection and sort status are lost upon clearing a filter. Expected Results: The selection and sort status must be preserved. about:buildconfig Build platform target i686-pc-cygwin Build tools Compiler Version Compiler flags $(CYGWIN_WRAPPER) cl 14.00.50727 -TC -nologo -W3 -Gy -Fd$(PDBFILE) $(CYGWIN_WRAPPER) cl 14.00.50727 -GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fd$(PDBFILE) Configure arguments --enable-application=browser --enable-update-channel=beta --enable-optimize --disable-debug --disable-tests --enable-static --disable-shared --enable-svg --enable-canvas --enable-default-toolkit=cairo-windows --enable-update-packaging --with-branding=browser/branding/unofficial
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-firefox3?
Target Milestone: --- → Firefox 3 alpha6
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → ehsan.akhgari
Status: ASSIGNED → NEW
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•17 years ago
|
||
The fix consists of three parts: 1. Save the initial selection state of the cookies tree when the dialog is opened. 2. Restore the sort order on the tree when clearing the input filter *before* restoring open state and selection (otherwise, restoring those two goes wrong.) 3. In the handler for pressing the Escape key on the filter textbox, check to see if the filter is already an empty string, and don't do anything in that case.
Attachment #267715 -
Flags: review?(mconnor)
Assignee | ||
Comment 2•17 years ago
|
||
Could we get a review on this before alpha6 freeze? Otherwise we have to retarget it to the next milestone.
Updated•17 years ago
|
Target Milestone: Firefox 3 alpha6 → Firefox 3 beta1
Assignee | ||
Comment 3•17 years ago
|
||
Comment on attachment 267715 [details] [diff] [review] Restore the sort order and selection status on clearing the filter Asking mano for a review, since mconnor's queue seems to be too busy.
Attachment #267715 -
Flags: review?(mconnor) → review?(mano)
Updated•17 years ago
|
Whiteboard: [need review Mano]
Target Milestone: Firefox 3 M7 → Firefox 3 M8
Comment 4•17 years ago
|
||
bumping to M9, hopefully Mano or myself get to this sooner...
Target Milestone: Firefox 3 M8 → Firefox 3 M9
Comment 5•17 years ago
|
||
moving out bugs that don't need to block b1
Target Milestone: Firefox 3 M9 → Firefox 3 M10
Assignee | ||
Comment 6•17 years ago
|
||
Comment on attachment 267715 [details] [diff] [review] Restore the sort order and selection status on clearing the filter Re-requesting review from mconnor...
Attachment #267715 -
Flags: review?(mano) → review?(mconnor)
Assignee | ||
Updated•17 years ago
|
Whiteboard: [need review Mano] → [has patch][need review mconnor]
Updated•17 years ago
|
Target Milestone: Firefox 3 M10 → Firefox 3 M11
Updated•17 years ago
|
Priority: -- → P5
Comment 7•17 years ago
|
||
Comment on attachment 267715 [details] [diff] [review] Restore the sort order and selection status on clearing the filter >+ // Restore sort order >+ var sortby = this._lastSortProperty; >+ if (sortby == "") { >+ this._lastSortAscending = false; >+ this.sort( "rawHost" ); >+ } >+ else { >+ this._lastSortAscending = !this._lastSortAscending; >+ this.sort( sortby ); >+ } r=me with the odd whitespace removed
Attachment #267715 -
Flags: review?(mconnor)
Attachment #267715 -
Flags: review+
Attachment #267715 -
Flags: approval1.9+
Updated•17 years ago
|
Flags: wanted-firefox3+
Flags: blocking-firefox3-
Flags: blocking-firefox3+
Whiteboard: [has patch][need review mconnor] → [has patch][has reviews]
Target Milestone: Firefox 3 Mx → Firefox 3 M11
Assignee | ||
Comment 8•17 years ago
|
||
(In reply to comment #7) > (From update of attachment 267715 [details] [diff] [review]) > > >+ // Restore sort order > >+ var sortby = this._lastSortProperty; > >+ if (sortby == "") { > >+ this._lastSortAscending = false; > >+ this.sort( "rawHost" ); > >+ } > >+ else { > >+ this._lastSortAscending = !this._lastSortAscending; > >+ this.sort( sortby ); > >+ } > > r=me with the odd whitespace removed Addressed this issue. This patch is ready for check-in.
Comment 10•17 years ago
|
||
Checking in browser/components/preferences/cookies.js; /cvsroot/mozilla/browser/components/preferences/cookies.js,v <-- cookies.js new revision: 1.16; previous revision: 1.15 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [has patch][has reviews]
Target Milestone: Firefox 3 M11 → Firefox 3 M10
Comment 11•17 years ago
|
||
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre) Gecko/2007112704 Minefield/3.0b2pre The sort mode seems to be retained, compared to 2007112004. I am not so sure about the selection — it changed to a different site sometimes.
Comment 12•17 years ago
|
||
v. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112704 Minefield/3.0b2pre ID:2007112704
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•