383729 - The "Try Again" button in error pages should be disabled when reloading the page

Status: NEW

(Firefox :: General, defect)

Description

[(no longer active)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5) Gecko/20070606 GranParadiso/3.0a5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5) Gecko/20070606 GranParadiso/3.0a5

On the trunk, the Try Again button in the error pages gets disabled after being clicked in order to prevent double clicks.  This should also happen when the user reloads the page via the toolbar button or the F5 key for example.

Reproducible: Always

Steps to Reproduce:
1. Go to this bug's URL.  A Server Not Found error is displayed.
2. Hit F5.
Actual Results:  
The Try Again button is not disabled.

Expected Results:  
The Try Again button should be disabled.

about:buildconfig

Build platform
target
i686-pc-cygwin

Build tools
Compiler 	Version 	Compiler flags
$(CYGWIN_WRAPPER) cl 	14.00.50727 	-TC -nologo -W3 -Gy -Fd$(PDBFILE)
$(CYGWIN_WRAPPER) cl 	14.00.50727 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fd$(PDBFILE)

Configure arguments
--enable-application=browser --enable-update-channel=beta --enable-optimize --disable-debug --disable-tests --enable-static --disable-shared --enable-svg --enable-canvas --enable-default-toolkit=cairo-windows --enable-update-packaging --with-branding=browser/branding/unofficial

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I'm not sure I see the point. A one-liner to disable the button to prevent accidental double clicks is one thing; adding a bunch of extra code to prevent someone from reloading twice is another. I don't think it's worth the trouble.

Comment 2

[(no longer active)]

(In reply to comment #1)
> I'm not sure I see the point. A one-liner to disable the button to prevent
> accidental double clicks is one thing; adding a bunch of extra code to prevent
> someone from reloading twice is another. I don't think it's worth the trouble.
> 

I think it's a matter of UI consistency.  Conceptually, the "Try Again" button and the Reload toolbar button are doing the same thing there.  Why should they provide different behavior at the UI level?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I don't agree that they're "conceptually the same". The "Try again" button is pretty specific to the error case we're reporting, whereas the reload button is always present and serves a general purpose. We don't disable the reload button at any other time. I could argue that doing it for error pages would lead to "inconsistent UI" :). Add to that the implementation difficulties (I don't see an easy to do this without adding a bunch of code), and I'm leaning pretty heavily towards WONTFIX.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Sorry, re-reading this again I see that I forgot what the original report was requesting :(. You want to disable the "Try again" button, not the reload button. I still don't think adding code to do this is worth the trouble.

Comment 5

[(no longer active)]

(In reply to comment #4)
> Sorry, re-reading this again I see that I forgot what the original report was
> requesting :(. You want to disable the "Try again" button, not the reload
> button. I still don't think adding code to do this is worth the trouble.
> 

Are they observers available for events such as the page reload, so that the code in the error page can subscribe to them and get notified when the page is reloaded?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

The error page might be able to just listen for "beforeunload" or "unload" and disable the button then.

Comment 7

[(no longer active)]

(In reply to comment #6)
> The error page might be able to just listen for "beforeunload" or "unload" and
> disable the button then.
> 

Does that require a large amount of code?  If I'm not mistaken, that should take only one event handler, right?  Or am I missing something?

Comment 8

[Travis G]

I DON'T LIKE THIS NEW DISABLED TRY AGAIN BUTTON!!!

I'm stuck on dialup, and the fricking pages often won't download the first few times when I'm trying to load 2 or 3 pages at the same times. It doesn't even connect to the website, so I need to hit try again after about 5-10 seconds - way before the timeout on the try-again, and it being disabled means I have to hit stop and try again. GRRRR about having to hit stop every time. Also (and this is a bug I'm filing in a minute) the blasted Try Again button is not re-enabled after hitting stop.

Travis

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> I DON'T LIKE THIS NEW DISABLED TRY AGAIN BUTTON!!!
> 
> I'm stuck on dialup, and the fricking pages often won't download the first few
> times when I'm trying to load 2 or 3 pages at the same times. It doesn't even
> connect to the website, so I need to hit try again after about 5-10 seconds -
> way before the timeout on the try-again, and it being disabled means I have to
> hit stop and try again. GRRRR about having to hit stop every time. Also (and
> this is a bug I'm filing in a minute) the blasted Try Again button is not
> re-enabled after hitting stop.

Sounds like that comment was meant for bug 364903. This bug isn't fixed.

You can use the reload button instead of the try again button, if you really want to repeatedly re-request the same page even though the request hasn't failed yet.

Please put any followup comments in bug 364903.