383846 - Tags could be lost when Sent folder index is rebuild (X-Mozilla-Keys: header is not written when copied to "Sent")

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Carsten Book [:Tomcat]]

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.4) Gecko/20070604 Thunderbird/2.0.0.4 ID:2007060411

Tag some messages in your send folder (like important) and rebuild the mail index.
-> Tags are lost after the rebuilding

Comment 1

[Carsten Book [:Tomcat]]

This bug reported during the testday and so far, i can reproduce this on local folders. 

Comment 2

[Carsten Book [:Tomcat]]

After some more testing: This could be reproduced also in other local folders, the workaround is to compact the folder (if there are deleted, moved messages) and after the compacting of the folder, the tags are not lost.

Comment 3

[David :Bienvenu]

Yup - we're not putting an x-mozilla-keys header in messages we copy to the sent folder, so we have no place to put the tags, until you compact the folder. Good catch.

Comment 4

[David :Bienvenu]

Attachment: proposed fix

write out an empty x-mozilla-keys header when doing local fcc.

Comment 5

[Scott MacGregor]

Comment on attachment 267807 [details] [diff] [review]
proposed fix

good find carsten!

Comment 7

[WADA:World Anti-bad-Duping Agency]

Adding "X-Mozilla-Keys:" in summary for ease of search.

Comment 8

[Daniel Veditz [:dveditz]]

Scott: I'll leave the "blocking" judgement up to you on this one. Also may want for an eventual tbird 1.5.0.13

Comment 9

[David :Bienvenu]

the problem doesn't exist in 1.5 - it's related to the new tag stuff (labels are tags in 2.0)

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So the request can be removed. Also adding dataloss keyword to indicate that we lose data.

Comment 11

[Scott MacGregor]

I'm going to minus this as a blocker but will request approval to land it on the branch as I think we want it, but I wouldn't block a release for it.

Comment 12

[Scott MacGregor]

Comment on attachment 267807 [details] [diff] [review]
proposed fix

we'd like this mailnews fix on the 1.8.1 branch for the next thunderbird release.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070614 Thunderbird/3.0a1pre ID:0000000000 [cairo] on a POP3 account.

This bug is not fixed for IMAP accounts! David, do you know an existing bug report which covers the IMAP part? If not I think it should be addressed within another bug report.

Comment 14

[David :Bienvenu]

if your server doesn't support custom keywords, Henrik, then there's nothing we can do about the imap case.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I activated custom keywords for my courier imap server and now it works. Thanks David.

Comment 16

[Daniel Veditz [:dveditz]]

Minusing for branch per comment 11, but we'll look at the approval request.

Comment 17

[Daniel Veditz [:dveditz]]

Comment on attachment 267807 [details] [diff] [review]
proposed fix

approved for 1.8.1.5, a=dveditz for release-drivers

Comment 18

[David :Bienvenu]

fixed for 1.8.1.5

Comment 19

[David :Bienvenu]

Attachment: patch landed on branch

the branch version of the patch is slightly different because of the filespec exorcism from the trunk.

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.5pre) Gecko/20070628 Thunderbird/2.0.0.5pre Mnenhy/0.7.5.0 ID:2007062903