383959 - Remember last preference pane across quit/relaunch

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect, P3)

Description

[Stuart Morgan]

Standard/HIG behavior is to remember the last-used preference pane and always open that one again, so we should be doing that. (I thought we had this filed, but I don't see it anywhere.)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Pulling some prefPane polish bugs to 1.6 as well, per roadmap discussions.

Comment 2

[froodian (Ian Leue)]

Attachment: Patch v1

Does the deed.

Comment 3

[Peter Jaros (:peeja)]

Comment on attachment 278877 [details] [diff] [review]
Patch v1

> - (void)selectPreferencePaneByIdentifier:(NSString *)identifier
> {
>   NSBundle *bundle = [NSBundle bundleWithIdentifier:identifier];
>+
>+  // If we can't find the identifier, select the default pane
>+  if (!bundle) {
>+    identifier = kDefaultPaneIdentifier;
>+    bundle = [NSBundle bundleWithIdentifier:identifier];
>+  }
>   
>-  if (bundle && ![mCurrentPaneIdentifier isEqualToString:identifier])
>+  if (![mCurrentPaneIdentifier isEqualToString:identifier])

In the original, we handled a failure to load the General pane; after the patch we assume it works.  On the other hand, it looks like the rest of the method deals with a nil bundle pretty well, and it mostly results in an error message.  I'm inclined to let it go, unless you or someone else has a better way to handle it, but I thought it was worth pointing out.

Beyond that, everything looks solid.  r+.

Comment 4

[Stuart Morgan]

Comment on attachment 278877 [details] [diff] [review]
Patch v1

sr=smorgan

Comment 5

[Stuart Morgan]

Whoops, this patch seems to have fallen through the cracks. Landed on trunk and MOZILLA_1_8_BRANCH.

Of course, I remembered that I forgot to attribute the patch a few seconds after committing, rather than before. Sorry Ian :(