384083 - Profile migrator is broken when first profile is from NS4

Status: RESOLVED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Bruno 'Aqualon' Escherl]

For a description of the problem have a look at http://groups.google.de/group/mozilla.dev.apps.seamonkey/browse_thread/thread/baffdffee338b3d1/201767b0eda5bc5b

char migratedStr[3] in Line 522 is set to "no" in the first loop and stays "no" for the other loops, although it's a local variable (perhaps caused by an optimization of the compiler). Setting it to 0 after declaration fixes the problem and the migrator works.

Comment 1

[Bruno 'Aqualon' Escherl]

Attachment: initialize migratedStr

Comment 2

[Bruno 'Aqualon' Escherl]

I also tested my old registry.dat with 4 profiles and the NS test profile and I can choose between those 4 profiles at migration.

Comment 3

[WADA:World Anti-bad-Duping Agency]

FYI.
Bug 379068 is already applied to trunk.
> Bug 379068 – Remove support for Netscape 4.x migration from the trunk

Comment 4

[Mark Banner (:standard8)]

(In reply to comment #3)
> FYI.
> Bug 379068 is already applied to trunk.
> > Bug 379068 – Remove support for Netscape 4.x migration from the trunk

Yes, but we're not trying to migrate Netscape 4.x profiles with this bug. The problem is when a registry file references old Netscape 4.x profiles directly (which weren't migrated) the migrator tries to skip them and ends up skipping the rest of the good profiles as well.

Comment 5

[Mark Banner (:standard8)]

I checked this in earlier.

Thanks for spending the time looking into this Bruno and doing the patch.