384192 - Mochitest needs to support subdomain tests

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We need to be able to write tests where files are located on different subdomains from each other. This is needed in order to test that setting document.domain does the right thing.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: v1

I've been way overthinking this problem; we don't need a proxy server.  Here's probably the shortest solution that'll work.  It'll break external resources in Mochitests when the tests are run with an existing proxy, but people shouldn't be doing that anyway.

The server changes are necessary because requests to HTTP/1.1 proxy servers use absolute paths, as a reminder.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 270055 [details] [diff] [review]
v1

Shifting review at sayrer's request...

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 270055 [details] [diff] [review]
v1

this looks reasonable to me. Sorry for the review lag.

Comment 4

[Jeff Walden [:Waldo]]

Gavin's stupid browser tests broke this patch.  :-P  The |if (crossDomain)| test in quit.js is fine as long as cross-domain.js is loaded -- but it's not in browser tests, because the harness loads a different set of files that includes quit.js but not cross-domain.js.  The ensuing exception caused the test to not exit, and I suspect it finished only when test timeout code code (silently!) detected the problem.

What's in place now works for doing cross-domain stuff, so this is pretty much fixed.  However, this snafu pointed out to me that we could put the proxy stuff in the profile easily enough and not muck around inside the browser.  This also has the added benefit of not having to reproduce the list of proxied servers in two locations.  I'm going to leave this open to do that.

Comment 5

[Jeff Walden [:Waldo]]

Attachment: Move everything into runtests.pl.in

Double-escaping sucks.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 275359 [details] [diff] [review]
Move everything into runtests.pl.in

agreed

Comment 7

[Jeff Walden [:Waldo]]

Comment on attachment 275359 [details] [diff] [review]
Move everything into runtests.pl.in

I suppose I need approval on this, actually...

This makes cross-domain support in Mochitests much simpler and easier to understand, and it also means harnesses don't have to each individually muck with preferences to set up the proxying.

Comment 8

[Jeff Walden [:Waldo]]

Comment on attachment 275359 [details] [diff] [review]
Move everything into runtests.pl.in

bsmedberg granted a blanket approval for test-harness changes under the current checkin rules, over IRC.

Comment 9

[Jeff Walden [:Waldo]]

Second version landed.

Comment 10

[(not currently active) Ted Mielczarek]

MochitestMassMove -- plz ignore.