Closed Bug 384208 Opened 18 years ago Closed 17 years ago

svg:pattern goes haywire when object rotated

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: djpnewton, Assigned: jtd)

References

(Depends on 1 open bug)

Details

Attachments

(7 files, 2 obsolete files)

testcase
1.20 KB, image/svg+xml
Details
testcase screenshot in opera
46.63 KB, image/png
Details
testcase screenshot with ff trunk
30.77 KB, image/png
Details
lots of pretty boxes
5.09 KB, image/svg+xml
Details
single rotated rect with pattern
1.05 KB, image/svg+xml
Details
single patterned rect, no rotation
1.05 KB, image/svg+xml
Details
scrolling working
13.89 KB, patch
longsonr
: review+
roc
: superreview+
roc
: approval1.9+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a6pre) Gecko/20070611 Minefield/3.0a6pre Build Identifier: I have a simple pattern that gets distorted when the object using the pattern is rotated. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Attached image testcase —
Assignee: nobody → jdaggett
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007080304 Minefield/3.0a7pre
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
Attached image lots of pretty boxes —
Flags: blocking1.9+
Attached patch lightly tested fix (obsolete) — — Splinter Review
Does the testcase in bug 377399 comment 1 still display OK?
(In reply to comment #8) > Does the testcase in bug 377399 comment 1 still display OK? Yes.
Attachment #279988 - Attachment is obsolete: true
Looks like this patch also fixes bug 391620, scaled patterns not rendered at device resolution.
(In reply to comment #11) > Looks like this patch also fixes bug 391620, scaled patterns not rendered at > device resolution. > In that case we need to do this for masks too, although not necessarily in this bug.
Scrolling doesn't work with this patch.
Scrolling appears broken in general right now. See bug 389498.
(In reply to comment #14) > Scrolling appears broken in general right now. See bug 389498. > AFAIK that only applies to masks.
This version seems to work with all the testcases I've tried. If you find somewhere it breaks, please let me know.
Attachment #280080 - Attachment is obsolete: true
Attachment #281248 - Flags: review?(longsonr)
Attachment #281248 - Flags: review?(longsonr) → review+
Attachment #281248 - Flags: superreview?(roc)
Attachment #281248 - Flags: superreview?(roc) → superreview+
Comment on attachment 281248 [details] [diff] [review] scrolling working Low risk patch that greatly improves the correctness of <svg:pattern>.
Attachment #281248 - Flags: approval1.9?
Blocks: 391620
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: