Closed Bug 384278 Opened 14 years ago Closed 2 years ago
minimized windows aren't restored maximized although they were maximized before minimizing
47 bytes, text/x-phabricator-request
|Details | Review|
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:126.96.36.199) Gecko/20070515 Firefox/188.8.131.52 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:184.108.40.206) Gecko/20070515 Firefox/220.127.116.11 When exiting and restarting Firefox, some of its windows are not restored to the original maximized state. Reproducible: Sometimes Steps to Reproduce: 1. Start FF, open 3 windows and some tab in them 2. make sure all 3 are maximized 3. menu File / Exit (and confirm closing multiple tabs, if asked) 4. start FF again Actual Results: 2 windows restored maximized, one not (it is about half screen wide) Expected Results: all 3 windows restored as maximized Some tabs open a password dialog* at start, maybe that interferes ? * - master password dialog (two times, known bug); HTTP login dialog
Maybe it happens only if the window was minimized at the moment of exiting. In that case this might be related to bug 327462
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:18.104.22.168) Gecko/20070515 Firefox/22.214.171.124 They all open maximized when I have checked "Show my windows and tabs from last time".
Indeed, we currently restore minimized windows in their original, unmaximized position since there's no easy way to tell whether a minimized window was formerly maximized or not.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Not all FF windows are restored maximized → minimized windows aren't restored maximized although they were maximized before minimizing
Yes, but before exiting, all windows are restored to their maximized state (because they display the "Close multiple tabs?" dialog). So actually there are no minimized windows when exisitng FF.
(In reply to comment #4) > So actually there are no minimized windows when exisitng FF. Due to the way Firefox currently works, the quit-application-granted notification is dispatched before the "Close multiple tabs?" prompt is shown - so SessionStore shuts down before the windows are restored and considers them as minimized at exit. That bit of this bug should be fixed by bug 383760.
I don't see what the problem is. You need 2 variables Bool Minimized Bool Maximized Those have only 4 possible combinations and each of them can and should be saved.
No idea where to look to find how this is currently handled, but in theory should be doable by making a call to GetWindowPlacement (http://msdn.microsoft.com/en-us/library/ms633518%28VS.85%29.aspx), check the WINDOWPLACEMENT.flags value for WPF_RESTORETOMAXIMIZED for each window, and if it's true then just set the same session restore flag that normally marks a window as being maximized when the program exits.
This bug still exists with Firefox v41.0.1 on Windows 7 (64-bit), and it's really quite tedious to maximise 10-20 windows every time I restart Firefox! (And actually it's gotten worse recently, which I'll describe in a separate bug report...) If it's not possible for Firefox to remember whether a windows was Maximised or not, then how about a user preference to force windows recorded as minimised to be Restored as maximised (or not).
> If it's not possible for Firefox to remember whether a windows was Maximised It is certainly possible, it just needs to be done
After performing the steps to reproduce the problem, the hotkey win+arrow-up does not work to maximize the window properly either. Needs to be maximized by dragging with mouse or clicking the maximize toolbar icon. Personally, I'm surprised this issue hasn't been addressed in 12 years, because at least for me this is the most annoying thing about FF right now.
Current window state in the sessionstore system includes `sizeMode` which can be "normal", "minimized", "maximized". However, the OS also remembers whether the window was "normal" or "maximized" before minimization to restore it appropriately. With this fix, sessionstore does likewise.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/8f6a8dc75308 Added additional state variable to store window state before window minimization. r=mikedeboer
You need to log in before you can comment on or make changes to this bug.