384279 - Strict warning "does not always return a value" even occurs when the function is missing its closing brace

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js> options("strict"); eval("function f(a) { if(a) return 1;")
typein:1: strict warning: function f does not always return a value:
typein:1: strict warning: function f(a) { if(a) return 1;
typein:1: strict warning: ..............................^
typein:1: SyntaxError: missing } after function body:
typein:1: function f(a) { if(a) return 1;
typein:1: ..............................^

I don't think the strict warning is necessary here :)

Comment 1

[Brian Crowder]

Why is this error not necessary?

Consider:  f(undefined)

Comment 2

[Jesse Ruderman]

Because the function doesn't even compile.  If the function had a closing brace, the warning would be appropriate.

Comment 3

[Brian Crowder]

Oh, hah!  I added that "}" assuming you had typod.

I get this in a current trunk build of the shell:
js> options("strict"); eval("function f(a) { if(a) return 1;")
typein:1: SyntaxError: missing } after function body:
typein:1: function f(a) { if(a) return 1;
typein:1: ..............................^

Comment 4

[Brian Crowder]

Oh, interesting.  This is different depending on how I start the shell!

crowdermac:~/mozilla/js/src crowder$ ./Darwin_DBG.OBJ/js -s
js> options("strict"); eval("function f(a) { if(a) return 1;")
typein:1: SyntaxError: missing } after function body:
typein:1: function f(a) { if(a) return 1;
typein:1: ..............................^
crowdermac:~/mozilla/js/src crowder$ ./Darwin_DBG.OBJ/js   
js> options("strict"); eval("function f(a) { if(a) return 1;")
typein:1: strict warning: function f does not always return a value:
typein:1: strict warning: function f(a) { if(a) return 1;
typein:1: strict warning: ..............................^
typein:1: SyntaxError: missing } after function body:
typein:1: function f(a) { if(a) return 1;
typein:1: ..............................^

Comment 5

[Jesse Ruderman]

options("strict") is a toggle.  Should it not be a toggle?

Comment 6

[Brian Crowder]

My bad, I thought it wasn't.

Comment 7

[Bob Clary [:bc] (inactive)]

All of the options are toggles and are a pita but I've got work arounds for it. If you want to change it, please wait for a bit until I can get caught up on other things.

Comment 8

[André Bargull [:anba]]

Strict warning "does not always return a value" was removed in http://hg.mozilla.org/mozilla-central/rev/a470d0cbe3fa (bug 1046964)