Closed Bug 384311 Opened 18 years ago Closed 18 years ago

Opening blank tab enough to cause document leak

Categories

(Toolkit :: Safe Browsing, defect)

x86
Linux
defect
Not set
critical

Tracking

()

VERIFIED FIXED

People

(Reporter: tor, Unassigned)

References

()

Details

(Keywords: memory-leak)

Steps to reproduce ------------------ * set firefox start page to "blank page" * quit firefox * set up leak logging (XPCOM_MEM_LEAK_LOG, leak-gauge setup, etc) * start firefox * press ^T (new tab) * quit firefox Results ------- Two nsHTMLDocument objects (amongst others) leaked according to XPCOM_MEM_LEAK_LOG. leak-gauge output: Leaked 2 out of 9 DOM Windows Leaked 29 out of 40 documents Leaked 0 out of 4 docshells
Does it still happen if you move aside the safe browsing JS components (nsSafeBrowsing*, nsUrlClassifier*)?
No leaks if those are moved aside: Leaked 0 out of 9 DOM Windows Leaked 0 out of 40 documents Leaked 0 out of 4 docshells
Depends on: 383269
This is making any leak debugging very hard since it's very easy to run into this leak which swamps any other leaks.
Severity: normal → critical
Component: Layout → Phishing Protection
Product: Core → Firefox
QA Contact: layout → phishing.protection
Jonas, Brendan is supposedly working on this in bug 383269.
The checkin for bug 383269 appears to have fixed this particular leak.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Flags: blocking-firefox3? → blocking-firefox3+
Still fixed after the second patch there, right?
Yes.
verified fixed using Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9b3pre) Gecko/2008010710 Minefield/3.0b3pre nsStringStats => mAllocCount: 16225 => mReallocCount: 3692 => mFreeCount: 16225 => mShareCount: 15617 => mAdoptCount: 2037 => mAdoptFreeCount: 2037 no leak -> Verified fixed
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.