384400 - Delete milestone message uses "ALL" incorrectly

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[timeless]

Steps:
1. Try to delete a milestone

Actual Results:
Confirmation
There are 19 bugs entered for this milestone! When you delete this milestone, ALL stored bugs will be reassigned to the default milestone of this product.

Do you really want to delete this milestone?

Expected Results:
When you delete this milestone, ALL of these bugs will be retargeted to the <>, the default milestone of this product.

(Where <> shows the current default milestone)

Comment 1

[timeless]

Attachment: fix wording

Comment 2

[Frédéric Buclin]

Comment on attachment 271440 [details] [diff] [review]
fix wording

>+    <b><blink>ALL</blink></b> of these [% terms.bugs %] will be retargeted to
>+    [% product.default_milestone FILTER html %], the default milestone for 
>+    the [% product.name FILTER html %] product.

You have to write [%+ product.default_milestone FILTER html %] (note the + sign), else no whitespace is added before the default milestone. Else it works fine.

Nit: wouldn't it be nicer with quotes around the milestone and product names?

r=LpSolit

Comment 3

[timeless]

personally i find the quotes around things annoying and ugly, iow, I'd sooner remove them all.

whoops, I really do know what the + means. Although I tend to move a word before it to avoid the problem.

Product "Foo" and Foo product are both fine imo. Note that there's actually a bug floating around about products/components named ""/''. 

Comment 4

[timeless]

Comment on attachment 271440 [details] [diff] [review]
fix wording

mozilla/webtools/bugzilla/template/en/default/admin/milestones/confirm-delete.html.tmpl 	1.8