384409 - move GetContextForContent to nsContentUtils and use it

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robert Longson [:longsonr]]

Attachment: patch

nsScriptElement has a GetContextForContent static function that is useful elsewhere.

Comment 1

[tor]

Comment on attachment 268340 [details] [diff] [review]
patch

> nsSVGSVGElement::GetBBox(nsIDOMSVGRect **_retval)
...
>-    frame->QueryInterface(NS_GET_IID(nsISVGChildFrame),(void**)&svgframe);
>+    CallQueryInterface(frame, &svgframe);

I think something unrelated snuck in your patch when you weren't looking.  r=tor with that removed.

Comment 2

[Robert Longson [:longsonr]]

(In reply to comment #1)

I can fix that on check in assuming there are no other issues.

Comment 3

[Robert Longson [:longsonr]]

Attachment: update to tip (replace new nsSVGUtils implementation)

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 269737 [details] [diff] [review]
update to tip (replace new nsSVGUtils implementation)

Please add a comment saying that the function returns null if aContent is not in a document (GetCurrentDoc returns null)

Comment 5

[Robert Longson [:longsonr]]

Attachment: version for check in with sr comments addressed

Comment 6

[Robert Longson [:longsonr]]

checked in.