Closed Bug 384409 Opened 14 years ago Closed 14 years ago

move GetContextForContent to nsContentUtils and use it

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: longsonr, Assigned: longsonr)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
nsScriptElement has a GetContextForContent static function that is useful elsewhere.
Attachment #268340 - Flags: review?(jonas)
Attachment #268340 - Flags: review?(tor)
Comment on attachment 268340 [details] [diff] [review]
patch

> nsSVGSVGElement::GetBBox(nsIDOMSVGRect **_retval)
...
>-    frame->QueryInterface(NS_GET_IID(nsISVGChildFrame),(void**)&svgframe);
>+    CallQueryInterface(frame, &svgframe);

I think something unrelated snuck in your patch when you weren't looking.  r=tor with that removed.
Attachment #268340 - Flags: review?(tor) → review+
(In reply to comment #1)

I can fix that on check in assuming there are no other issues.

Attachment #268340 - Attachment is obsolete: true
Attachment #269737 - Flags: superreview?(jonas)
Attachment #269737 - Flags: review?(jonas)
Attachment #268340 - Flags: review?(jonas)
Comment on attachment 269737 [details] [diff] [review]
update to tip (replace new nsSVGUtils implementation)

Please add a comment saying that the function returns null if aContent is not in a document (GetCurrentDoc returns null)
Attachment #269737 - Flags: superreview?(jonas)
Attachment #269737 - Flags: superreview+
Attachment #269737 - Flags: review?(jonas)
Attachment #269737 - Flags: review+
Attachment #269737 - Attachment is obsolete: true
checked in.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.