move GetContextForContent to nsContentUtils and use it

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
12 years ago
2 months ago

People

(Reporter: longsonr, Assigned: longsonr)

Tracking

Trunk
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

12 years ago
Posted patch patch (obsolete) — Splinter Review
nsScriptElement has a GetContextForContent static function that is useful elsewhere.
Attachment #268340 - Flags: review?(jonas)
Assignee

Updated

12 years ago
Attachment #268340 - Flags: review?(tor)

Comment 1

12 years ago
Comment on attachment 268340 [details] [diff] [review]
patch

> nsSVGSVGElement::GetBBox(nsIDOMSVGRect **_retval)
...
>-    frame->QueryInterface(NS_GET_IID(nsISVGChildFrame),(void**)&svgframe);
>+    CallQueryInterface(frame, &svgframe);

I think something unrelated snuck in your patch when you weren't looking.  r=tor with that removed.
Attachment #268340 - Flags: review?(tor) → review+
Assignee

Comment 2

12 years ago
(In reply to comment #1)

I can fix that on check in assuming there are no other issues.

Assignee

Comment 3

12 years ago
Attachment #268340 - Attachment is obsolete: true
Attachment #269737 - Flags: superreview?(jonas)
Attachment #269737 - Flags: review?(jonas)
Attachment #268340 - Flags: review?(jonas)
Comment on attachment 269737 [details] [diff] [review]
update to tip (replace new nsSVGUtils implementation)

Please add a comment saying that the function returns null if aContent is not in a document (GetCurrentDoc returns null)
Attachment #269737 - Flags: superreview?(jonas)
Attachment #269737 - Flags: superreview+
Attachment #269737 - Flags: review?(jonas)
Attachment #269737 - Flags: review+
Assignee

Comment 6

12 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Flags: in-testsuite-
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.