Closed
Bug 384513
Opened 18 years ago
Closed 18 years ago
Turn on pragma visibility on mac configure tests
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
2.33 KB,
patch
|
mark
:
review+
stanshebs
:
superreview+
|
Details | Diff | Splinter Review |
The visibility checks in configure make some wrong checks and elf-specific voodoo. With this patch I get "non-external (was a private external)" symbols refs instead of standard external refs which should fix the libxul-mac perf problems, if I'm lucky and the stars align correctly.
Attachment #268442 -
Flags: superreview?(stanshebs)
Attachment #268442 -
Flags: review?(mark)
|
||
Updated•18 years ago
|
Attachment #268442 -
Flags: review?(mark) → review+
|
||
Comment 1•18 years ago
|
||
Comment on attachment 268442 [details] [diff] [review]
Fix visibility hecks, rev 1
These look like the right fixes for the immediate problem of the configure tests, but I'm not clear on what the libxul performance problem is, exactly.
Attachment #268442 -
Flags: superreview?(stanshebs) → superreview+
|
Assignee | |
Comment 2•18 years ago
|
||
Without this patch, references to "mozilla-internal" symbols were
U __Z12ToNewCStringRK19nsACString_internal
With this patch, they are
u __Z12ToNewCStringRK19nsACString_internal
I do not know for certain that this will help performance, but a little mach-o reading and some intuition says that it will because we are avoiding a name lookup.
|
|
Assignee | |
Comment 3•18 years ago
|
||
Fixed on trunk. I'm going to watch the perf numbers for a while, because they seem to be fluctuating oddly.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•