384563 - [snav] SpatialNavigation contracts are a mess

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[timeless]

SpatialNavigation_ContractID

If you can't find what you're looking for, you can always search for it.
Defined as a preprocessor macro in:

    * extensions/spatialnavigation/src/nsSpatialNavigationService.cpp (View change log or Blame annotations)
          o line 239 

Referenced in:

This page was automatically generated by MXR-test. 

Note that there are two contracts, the former (with proper ; style) is unused:
 239 #define SpatialNavigation_ContractID "@mozilla.org/spatialNavigation/service;1"
the latter (without ; style, but with all lowercase contracting) is used:
 245 #define SpatialNavigationService_ContractID "@mozilla.org/spatialnavigation/service"

I'm basically porting the entire codebase to js to test an alternate implementation. I've found all sorts of things I don't like in the C++ impl, some of which I think I've already correct in some lost tree. I'm just noting this one here. I may or may not do something about it. I expect to replace the implementation with a reported c++ version once I'm done.

Anyone is free to fix this, there should be one contract, and it should be:
"@mozilla.org/spatialnavigation/service;1"

unused defines are bad.

Comment 1

[Alex Vincent [:WeirdAl]]

Attachment: patch, v1

This patch also fixes a bug with service registration via app-startup... seems spatial nav wasn't registered as a service.

Comment 2

[Doug Turner (:dougt)]

timeless, where is the js version?

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 272721 [details] [diff] [review]
patch, v1

ajvincent.  looks fine.

version: 1.11