384569 - When drawing to a scaled canvas with drawWindow, native buttons are enormous

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P4)

Description

[Dave Townsend [:mossop]]

Attachment: screenshot

The rest of the window draws in the canvas correctly, but the buttons are massive.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

this is a dupe of some other bug whose number I forgot --- basically, Cocoa native theming needs to do what Linux and Windows do, if a non-trivial transform is in effect, render via a temporary surface.

Comment 2

[Colin Barrett [:cbarrett]]

This is an artifact of us using the compositeToPoint: method instead of drawAtPoint:.

I'll come up with a fix for this next week.

Comment 3

[Colin Barrett [:cbarrett]]

I think we should fix this by:

1) removing our use of an offscreen buffer to draw scaled buttons
2) instead do something like:

gSave
SetScale(scaleFactor /* we already compute this */)
Draw
gRestore

This would also make my patch for bug 397209 unneeded.

Comment 4

[Colin Barrett [:cbarrett]]

I tried this idea out the other day and HITheme barfed. D'oh :(

Good news is that NSCell works fine.

Comment 5

[Dave Townsend [:mossop]]

Attachment: testcase (save locally to run)

This is a testcase to demonstrate the issue. Since it uses the drawWindow call you must run it from a local disk and it will ask for elevated privileges on load.

It contains a 400x400 area at the top of the page with some text and buttons. Below is a 200x200 canvas. The top area is scaled down and drawn onto the canvas.

The button widgets draw as if there was no scaling at all, the text (including the text labels of the buttons) are correctly scaled.

Comment 6

[Josh Aas]

fixed by 407093