384575 - Remove SeaMonkey autoscroll in favor of toolkit's

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Robert Kaiser]

The SeaMonkey autoscroll support of bug 304563 has been superseded by a port of it to toolkit's <browser> in bug 242621, so we should remove the SeaMonkey-specific solution and use the toolkit one instead, I guess.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Adding this to my to-do list.  If somebody else is going to get to it before I do, feel free to swipe it.

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

I tested this for about 30 seconds.  My mailnews is totally busted, though, so I couldn't test that part.

We're taking advantage of winstripe's icon with this patch.

Comment 3

[[e-mail]]

Comment on attachment 268875 [details] [diff] [review]
patch

Works great in Classic but fails miserably in Modern.

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch v2

So modern doesn't pick up winstripe theming?  Fun.

Comment 5

[[e-mail]]

(In reply to comment #4)
>So modern doesn't pick up winstripe theming?  Fun.
Um, no, themes are entirely separate from each other :-P

Comment 6

[[e-mail]]

Comment on attachment 269003 [details] [diff] [review]
patch v2

>Index: mozilla/themes/modern/jar.mn
...
>Index: mozilla/themes/modern/jar.mn
Oops ;-)

>+* skin/modern/globa/global.css                                     (global/global.css)
Typo but see below

>+%ifdef XP_WIN
a) What about GTK?
b) Modern is supposed to be platform-independent. I persuaded Mano that it would be a good idea to restore the translucent/transparent attributes so that third party themes didn't have to fiddle around with platform-specific packages to achieve the correct result. Unless of course you'd like to work out how to make platform-specific themes ;-)

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch for toolkit

Sorry for the 1-line context, but I have other garbage in browser.xml and this was the easiest way to just get the part I wanted ;)

This is identical to the logic we used in SeaMonkey.

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch (suite part, depends on toolkit patch)

Comment 9

[Asaf Romano (gone)]

Comment on attachment 269519 [details] [diff] [review]
patch for toolkit

As long as you don't pre-process in-tree themes...

Comment 10

[Asaf Romano (gone)]

Er, as long as you don't use these attribute for pre-processable theme.

Comment 11

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Unrotted the toolkit patch and checked both patches in.