384625 - Absolute Positioning grabber (mGrabber) hidden and inaccesible

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Art Skiles]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070615 SeaMonkey/2.0a1pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/20070615 SeaMonkey/2.0a1pre

The "grabber" becomes hidden behind other page elements during editing. Shouldn't the grabbers z-index be maxed out in EditorOverride.css or /mozilla/editor/libeditor/htmlnsHTMLAbsPosition.cpp ( RefreshGrabber() )?

Reproducible: Always

Steps to Reproduce:
1.Select and move an absolutely positioned element.
2.Release over an element with a higher z-index.
3.
Actual Results:  
grabber border remains but crosshairs gone and can't move.

Expected Results:  
grabber remains visible at all times. (z-index should be maxed)

Comment 1

[Misak Khachatryan]

Your URL don't work. Site temporarily closed. Can you retest with latest builds ?

Comment 2

[Art Skiles]

Still happens in the following build:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9

Hopefully you didn't mean the latest nightly build.

To reproduce:

1) Select or create a div from text off the default seamonkey startup page and select layer button (make it pos abs).

2) Grab layer and move atop seamonkey logo at top of page.

3) Grabber becomes covered.

Again, this seems like an easy fix by maxing out the grabber z-index.

Comment 3

[Misak Khachatryan]

Confirming.

Comment 4

[Art Skiles]

Attachment: Sets z-index of the mozGrabber.

Possible patch for "grabber disappearing".

Comment 5

[Reed Loden [:reed]]

Comment on attachment 317368 [details] [diff] [review]
Sets z-index of the mozGrabber.

I'm not a valid reviewer for this code. Maybe try [e-mail] instead?

Comment 6

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 317368 [details] [diff] [review]
Sets z-index of the mozGrabber.

r=[e-mail]
go ahead

Comment 7

[Reed Loden [:reed]]

The bug isn't resolved until the patch has been landed.

Comment 8

[Reed Loden [:reed]]

Comment on attachment 317368 [details] [diff] [review]
Sets z-index of the mozGrabber.

I believe this needs SR, too.

Comment 9

[[e-mail]]

Comment on attachment 317368 [details] [diff] [review]
Sets z-index of the mozGrabber.

>+  z-index: 2147483646;
> }
>
> /* INLINE TABLE EDITING */
>
> a[\_moz_anonclass="mozTableAddColumnBefore"] {
>   position: absolute;
>   z-index: 2147483647; /* max value for this property */
Though I guess copying this line would be just that little bit better still!

Comment 10

[Art Skiles]

Attachment: Max out grabber z-index.

Bumped up to max z-index value.

Comment 11

[Art Skiles]

Going ahead with checkin-needed since we have superreview+.

Comment 12

[Reed Loden [:reed]]

Checking in editor/composer/src/res/EditorOverride.css;
/cvsroot/mozilla/editor/composer/src/res/EditorOverride.css,v  <--  EditorOverride.css
new revision: 1.41; previous revision: 1.40
done