remove __callee__ from Call objects, or fix its prototype leak hazard

RESOLVED FIXED in mozilla1.9alpha8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: brendan, Assigned: brendan)

Tracking

Trunk
mozilla1.9alpha8
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Summary says it all. In light of JS2/ES4 with its stack inspection stuff we would rather do away with __callee__, but it might be used enough that we'll keep it, at least until Mozilla 2. Anyone with knowledge of uses in our tree or addons, please pipe up.

/be
(Assignee)

Comment 1

11 years ago
See http://developer.mozilla.org/es4/proposals/stack_inspection.html for the ES4 stack reflection proposal.

/be
(Assignee)

Comment 2

11 years ago
Created attachment 268728 [details] [diff] [review]
fix

__callee__ was silly, it did not work unless the function containing it was heavyweight (scoped by a call object), so it could end up binding to some outer function call's callee. This patch removes it. Igor likes removal of code, so I hope to get fast r+ ;-).

/be
Attachment #268728 - Flags: review?(igor)

Comment 3

11 years ago
Comment on attachment 268728 [details] [diff] [review]
fix

I indeed like the patches mostly with minuses.
Attachment #268728 - Flags: review?(igor) → review+
(Assignee)

Comment 4

11 years ago
Fixed on trunk:

js/src/jsfun.c 3.189

/be
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.