Closed
Bug 384680
Opened 17 years ago
Closed 17 years ago
Round-trip change with parenthesized useless expression
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.9alpha6
People
(Reporter: jruderman, Assigned: brendan)
References
Details
(Keywords: regression, testcase)
Attachments
(1 file, 1 obsolete file)
2.39 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
js> f = (function() { (3); })
function () {
3;
}
js> eval("(" + f + ")");
function () {
}
This completely breaks jsfunfuzz's ability to detect incorrect decompilation.
Assignee | ||
Comment 1•17 years ago
|
||
Regression from patch for bug 383674.
I took the opportunity to eliminate redundant tests and use a switch instead of an if-else chain.
/be
Assignee | ||
Updated•17 years ago
|
OS: Mac OS X → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha6
Assignee | ||
Comment 2•17 years ago
|
||
Attachment #268616 -
Attachment is obsolete: true
Attachment #268617 -
Flags: review?(mrbkap)
Attachment #268616 -
Flags: review?(mrbkap)
Updated•17 years ago
|
Attachment #268617 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 3•17 years ago
|
||
Fixed on trunk:
js/src/jsemit.c 3.258
/be
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 4•17 years ago
|
||
/cvsroot/mozilla/js/tests/js1_5/extensions/regress-384680.js,v <-- regress-384680.js
initial revision: 1.1
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•