384759 - Fix "startup override check" code to understand new "pre" versions

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Part of our "do we show the user a special page for a release version" code is still looking for the old +/no-+ system of nightlies vs. releases.  We're no longer in that world.

470   // for non-nightly builds, show a special start page
471   PreferenceManager* prefManager = [PreferenceManager sharedInstance];
472   NSString* vendorSubString = [prefManager getStringPref:"general.useragent.vendorSub" withSuccess:NULL];
473   if (![vendorSubString hasSuffix:@"+"]) {
474     // has the user seen this already?

If I'm reading the code right, all this means right now is that we're doing extra checking (every build) instead of weeding out the nightlies immediately, but I'm not sure.  This startup override stuff confuses me greatly....

Comment 1

[Stuart Morgan]

Attachment: fix

Good catch; this was causing us to show the override page in nightly builds.

Comment 2

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Er, for completeness's sake, do we want this on the 1_5 branch and/or 1_8_0?  In theory no one will be using nightlies from those branches, but both now have the "pre" nomenclature.